linux-kernel - Re: [PATCH v6 1/3] iio: adc: add max11410 adc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202209280803.M8UiPkl7-lkp@intel.com>
Date:   Wed, 28 Sep 2022 08:47:47 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ibrahim Tilki <Ibrahim.Tilki@...log.com>, jic23@...nel.org
Cc:     kbuild-all@...ts.01.org, Ibrahim Tilki <Ibrahim.Tilki@...log.com>,
        linux-iio@...r.kernel.org, Nuno.Sa@...log.com,
        Nurettin.Bolucu@...log.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 1/3] iio: adc: add max11410 adc driver

Hi Ibrahim,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on jic23-iio/togreg]
[also build test ERROR on next-20220927]
[cannot apply to linus/master v6.0-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ibrahim-Tilki/iio-adc-add-max11410-adc-driver/20220927-222034
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: sh-allmodconfig
compiler: sh4-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/795af4fe22908d760228ef3adb1f59021df2097c
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ibrahim-Tilki/iio-adc-add-max11410-adc-driver/20220927-222034
        git checkout 795af4fe22908d760228ef3adb1f59021df2097c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/iio/adc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/iio/adc/max11410.c: In function 'max11410_read_reg':
>> drivers/iio/adc/max11410.c:190:24: error: implicit declaration of function 'get_unaligned_be24'; did you mean 'get_unalign_ctl'? [-Werror=implicit-function-declaration]
     190 |                 *val = get_unaligned_be24(&st->scan.data);
         |                        ^~~~~~~~~~~~~~~~~~
         |                        get_unalign_ctl
   cc1: some warnings being treated as errors


vim +190 drivers/iio/adc/max11410.c

   179	
   180	static int max11410_read_reg(struct max11410_state *st, unsigned int reg,
   181				     int *val)
   182	{
   183		int ret;
   184	
   185		if (max11410_reg_size(reg) == 3) {
   186			ret = regmap_bulk_read(st->regmap, reg, &st->scan.data, 3);
   187			if (ret)
   188				return ret;
   189	
 > 190			*val = get_unaligned_be24(&st->scan.data);
   191			return 0;
   192		}
   193	
   194		return regmap_read(st->regmap, reg, val);
   195	}
   196	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (241876 bytes)