linux-kernel - Re: [PATCH] ASoC: Intel: sof_rt5682: remove SOF_RT1015_SPEAKER_AMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d94a9abd-95ca-09ba-ab24-e4c38b832678@linux.intel.com>
Date:   Wed, 28 Sep 2022 10:38:29 +0200
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     "Lu, Brent" <brent.lu@...el.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Cc:     "Rojewski, Cezary" <cezary.rojewski@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>,
        Takashi Iwai <tiwai@...e.com>,
        Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        "Chiang, Mac" <mac.chiang@...el.com>,
        Mark Brown <broonie@...nel.org>,
        Ajye Huang <ajye.huang@...il.com>,
        Bard Liao <yung-chuan.liao@...ux.intel.com>,
        "Gopal, Vamshi Krishna" <vamshi.krishna.gopal@...el.com>,
        "Zhi, Yong" <yong.zhi@...el.com>
Subject: Re: [PATCH] ASoC: Intel: sof_rt5682: remove
 SOF_RT1015_SPEAKER_AMP_100FS flag



On 9/27/22 15:16, Lu, Brent wrote:
>>> +		case SND_SOC_DAIFMT_DSP_A:
>>> +		case SND_SOC_DAIFMT_DSP_B:
>>> +			/* 4-slot TDM */
>>> +			ret = snd_soc_dai_set_tdm_slot(codec_dai,
>>> +						       rt1015_tdm_mask[i].tx,
>>> +						       rt1015_tdm_mask[i].rx,
>>> +						       4,
>>> +						       params_width(params));
>>
>> The changes look ok, just wondering if we can avoid hard-coding those 4 values.
>> Can we not get the number of TDM slots from topology and/or dailink
>> configuration?
>>
>>
> 
> I think TDM slot number is possible but not TX/RX mask. What we have in topology
> is union of tx/rx mask of all channels. We don't know the mask of specific channel in
> DAI_CONFIG.
> 
> DAI_CONFIG(SSP, 0, BOARD_HP_BE_ID, SSP0-Codec,
>         SSP_CONFIG(I2S, SSP_CLOCK(mclk, 19200000, codec_mclk_in),
>                 SSP_CLOCK(bclk, 2400000, codec_slave),
>                 SSP_CLOCK(fsync, 48000, codec_slave),
>                 SSP_TDM(2, 25, 3, 3),

the 3 3 is precisely the channel mask!

>                 SSP_CONFIG_DATA(SSP, 0, 24, 0, 0, 0, SSP_CC_BCLK_ES)))')
> 
> Regards,
> Brent
>