linux-kernel - Re: [RFC PATCH 7/9] cxl/test: Add generic mock events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220928104934.00000f6a@huawei.com>
Date:   Wed, 28 Sep 2022 10:49:34 +0100
From:   Jonathan Cameron <Jonathan.Cameron@...wei.com>
To:     Ira Weiny <ira.weiny@...el.com>
CC:     "Williams, Dan J" <dan.j.williams@...el.com>,
        "Schofield, Alison" <alison.schofield@...el.com>,
        "Verma, Vishal L" <vishal.l.verma@...el.com>,
        Ben Widawsky <bwidawsk@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Davidlohr Bueso <dave@...olabs.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-cxl@...r.kernel.org" <linux-cxl@...r.kernel.org>
Subject: Re: [RFC PATCH 7/9] cxl/test: Add generic mock events

On Tue, 27 Sep 2022 09:13:58 -0700
Ira Weiny <ira.weiny@...el.com> wrote:

> On Tue, Sep 27, 2022 at 02:56:23PM +0100, Jonathan Cameron wrote:
> > On Mon, 26 Sep 2022 14:39:52 -0700
> > Ira Weiny <ira.weiny@...el.com> wrote:
> >   
> > > On Tue, Sep 20, 2022 at 09:17:48AM -0700, Jonathan Cameron wrote:  
> > > > On Thu, 15 Sep 2022 11:53:29 -0700
> > > > Ira Weiny <ira.weiny@...el.com> wrote:
> > > >     
> > > > > On Thu, Aug 25, 2022 at 12:31:19PM +0100, Jonathan Cameron wrote:    
> > > > > > On Fri, 12 Aug 2022 22:32:41 -0700
> > > > > > ira.weiny@...el.com wrote:
> > > > > >       
> > > > > > > From: Ira Weiny <ira.weiny@...el.com>
> > > > > > > 
> > > > > > > Facilitate testing basic Get/Clear Event functionality by creating
> > > > > > > multiple logs and generic events with made up UUID's.
> > > > > > > 
> > > > > > > Data is completely made up with data patterns which should be easy to
> > > > > > > spot in trace output.      
> > > > > > Hi Ira,
> > > > > > 
> > > > > > I'm tempted to hack the QEMU emulation for this in with appropriately
> > > > > > complex interface to inject all the record types...      
> > > > > 
> > > > > Every time I look at the QEMU code it makes my head spin.  :-(    
> > > > 
> > > > You get used to it ;)`    
> > > 
> > > I'm trying...  :-/
> > > 
> > > Question though:
> > > 
> > > Is there a call in qemu which is equivalent to cpu_to_leXX()?  The
> > > exec/cpu-all.h is having compilation issues for me because the
> > > TARGET_BIG_ENDIAN is not defined (it is defined in a meson generated header).
> > > 
> > > So I'm afraid that the tswapXX() calls are not what I'm supposed to use.  Is
> > > this true?  Are those some sort of internal call?  
> > I'm confused.  There is cpu_to_le16 in "qemu/bswap.h"  
> 
> <sigh> I don't know how I missed it.  Sorry.
> 
> > 
> > I suspect we've played a bit fast and loose with endianness in a few places in
> > current qemu code and should probably check all that sometime.  
>  
> Yea nothing in hw/cxl seems to use any swapping.  I suppose only little endian
> hosts have been used thus far?

Exactly and I'm not sure when we'll see any big endian emulated hosts.  We should fix that,
but lots of other things on todo list, so it's not particularly high on the list
+ getting a test environment up is going to be non trivial.

J
> 
> I greped for 'ENDIAN' and found the tswap* calls.  I guess I should have
> grepped for 'cpu_to'!  That found it right away!  :-/  :-D
> 
> Sorry for the distraction,
> Ira
> 
> > Jonathan
> > 
> > 
> >   
> > > 
> > > Ira  
> >