linux-kernel - Re: [PATCH v2 1/3] watchdog: twl4030_wdt: add missing mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220928011154.GA1700137@roeck-us.net>
Date:   Tue, 27 Sep 2022 18:11:54 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Jonathan Cameron <jic23@...nel.org>, Lee Jones <lee@...nel.org>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Tony Lindgren <tony@...mide.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-iio@...r.kernel.org, linux-watchdog@...r.kernel.org,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] watchdog: twl4030_wdt: add missing
 mod_devicetable.h include

On Tue, Sep 27, 2022 at 08:46:09AM -0700, Dmitry Torokhov wrote:
> The driver is using of_device_id and therefore needs to include
> mod_devicetable.h header. We used to get this definition indirectly via
> inclusion of matrix_keypad.h from twl.h, but we are cleaning up
> matrix_keypad.h from unnecessary includes.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
> 
> v2: changed from of.h to mod_devicetable.h per Andy Shevchenko
> 
>  drivers/watchdog/twl4030_wdt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/twl4030_wdt.c b/drivers/watchdog/twl4030_wdt.c
> index 355e428c0b99..36b4a660928d 100644
> --- a/drivers/watchdog/twl4030_wdt.c
> +++ b/drivers/watchdog/twl4030_wdt.c
> @@ -9,6 +9,7 @@
>  #include <linux/types.h>
>  #include <linux/slab.h>
>  #include <linux/kernel.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/watchdog.h>
>  #include <linux/platform_device.h>
>  #include <linux/mfd/twl.h>
> -- 
> 2.38.0.rc1.362.ged0d419d3c-goog
>