linux-kernel - Re: [PATCH v4 2/2] perf: arm_cspmu: Add support for NVIDIA SCF and MCF attribute

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Sep 2022 11:47:11 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     Besar Wicaksono <bwicaksono@...dia.com>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will@...nel.org" <will@...nel.org>,
        "mark.rutland@....com" <mark.rutland@....com>
Cc:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "sudeep.holla@....com" <sudeep.holla@....com>,
        "thanu.rangarajan@....com" <thanu.rangarajan@....com>,
        "Michael.Williams@....com" <Michael.Williams@....com>,
        Thierry Reding <treding@...dia.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Vikram Sethi <vsethi@...dia.com>,
        "mathieu.poirier@...aro.org" <mathieu.poirier@...aro.org>,
        "mike.leach@...aro.org" <mike.leach@...aro.org>,
        "leo.yan@...aro.org" <leo.yan@...aro.org>
Subject: Re: [PATCH v4 2/2] perf: arm_cspmu: Add support for NVIDIA SCF and
 MCF attribute

On 28/09/2022 02:38, Besar Wicaksono wrote:
> 
> 
>> -----Original Message-----
>> From: Suzuki K Poulose <suzuki.poulose@....com>
>> Sent: Tuesday, September 27, 2022 6:43 AM
>> To: Besar Wicaksono <bwicaksono@...dia.com>; robin.murphy@....com;
>> catalin.marinas@....com; will@...nel.org; mark.rutland@....com
>> Cc: linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
>> linux-tegra@...r.kernel.org; sudeep.holla@....com;
>> thanu.rangarajan@....com; Michael.Williams@....com; Thierry Reding
>> <treding@...dia.com>; Jonathan Hunter <jonathanh@...dia.com>; Vikram
>> Sethi <vsethi@...dia.com>; mathieu.poirier@...aro.org;
>> mike.leach@...aro.org; leo.yan@...aro.org
>> Subject: Re: [PATCH v4 2/2] perf: arm_cspmu: Add support for NVIDIA SCF
>> and MCF attribute
>>
>> External email: Use caution opening links or attachments
>>
>>
>> On 14/08/2022 19:23, Besar Wicaksono wrote:
>>> Add support for NVIDIA System Cache Fabric (SCF) and Memory Control
>>> Fabric (MCF) PMU attributes for CoreSight PMU implementation in
>>> NVIDIA devices.
>>>
>>> Signed-off-by: Besar Wicaksono <bwicaksono@...dia.com>

>>> +struct nv_cspmu_match {
>>> +     u32 prodid;
>>> +     u32 prodid_mask;
>>> +     u64 filter_mask;
>>> +     const char *name_pattern;
>>> +     enum nv_cspmu_name_fmt name_fmt;
>>> +     struct attribute **event_attr;
>>> +     struct attribute **format_attr;
>>> +};
>>> +
>>> +static const struct nv_cspmu_match nv_cspmu_match[] = {
>>
>> Similar coding style nit below.
>>
> 
> Sure, I will update this.
> 
>>
>> Otherwise,
>>
>> Acked-by: Suzuki K Poulose <suzuki.poulose@....com>
> 
> Thanks!
> 
> Unfortunately, we need to update the name of the PMUs and remove
> some of the attributes in NVIDIA implementation. This requires a change
> in nvidia_cspmu.c and nvidia-pmu.rst. I hope you are fine if I include this
> change on v5 patch.

That should be fine.

Suzuki