linux-kernel - Re: [PATCH v3 3/4] Documentation: rs485: Mention uart_get_rs485

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4df6e19-5390-3ce8-eb7f-8059115187d0@linux.intel.com>
Date:   Wed, 28 Sep 2022 14:52:02 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
cc:     Jiri Slaby <jirislaby@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 3/4] Documentation: rs485: Mention
 uart_get_rs485_mode()

On Wed, 28 Sep 2022, Andy Shevchenko wrote:

> On Wed, Sep 28, 2022 at 2:05 PM Ilpo Järvinen
> <ilpo.jarvinen@...ux.intel.com> wrote:
> 
> >     The device tree can also provide RS485 boot time parameters
> > -   [#DT-bindings]_. The driver is in charge of filling this data structure
> > -   from the values given by the device tree.
> > +   [#DT-bindings]_. The serial core fills the struct serial_rs485 from the
> > +   values given by the device tree when driver calls uart_get_rs485_mode().
> 
> the driver
> 
> Feels like this should be before the previous patch and actually have
> a Fixes tag.

I don't feel it would be an appropriate tag for this kind of cases 
where documentation is simply lacking behind what the core code now 
offers.

-- 
 i.