linux-kernel - Re: [PATCH] Documentation: Kunit: Use full path to .kunitconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be928578-6453-5cf1-32da-322aebe2cee5@gmail.com>
Date:   Wed, 28 Sep 2022 19:51:09 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Khalid Masum <khalid.masum.92@...il.com>,
        Brendan Higgins <brendan.higgins@...ux.dev>,
        David Gow <davidgow@...gle.com>,
        Jonathan Corbet <corbet@....net>,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Documentation: Kunit: Use full path to .kunitconfig

On 9/28/22 11:00, Khalid Masum wrote:
> The numbered list contains full path to every files that need to be
> modified or created in order to implement misc-example kunit test.
> Except for .kunitconfig. Which might make a newcommer confused about
> where the file exists. Since there are multiple .kunitconfig files.
> 
> Fix this by using the full path to .kunitconfig.
> 

Better say:

```
The fourth list item on writing test cases instructs adding Kconfig
fragments to .kunitconfig, which should have been full path to the file
(.kunit/.kunitconfig).
```

> -4. Add the following lines to ``.kunitconfig``:
> +4. Add the following lines to ``.kunit/.kunitconfig``:
>  
>  .. code-block:: none
>  

I think "Add the following lines" should be changed to something more
descriptive in regards to what these lines are about (which in this
case should be "Add following configuration fragments").

Thanks.

-- 
An old man doll... just what I always wanted! - Clara