linux-kernel - Re: [PATCH V3] mISDN: fix use-after-free bugs in l1oip timer handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51008dca.fbc35.1838448187b.Coremail.duoming@zju.edu.cn>
Date:   Wed, 28 Sep 2022 21:27:40 +0800 (GMT+08:00)
From:   duoming@....edu.cn
To:     "Jakub Kicinski" <kuba@...nel.org>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        isdn@...ux-pingi.de
Subject: Re: [PATCH V3] mISDN: fix use-after-free bugs in l1oip timer
 handlers

Hello,

On Tue, 27 Sep 2022 17:26:18 -0700 Jakub Kicinski wrote:

> On Sat, 24 Sep 2022 10:18:42 +0800 Duoming Zhou wrote:
> > +	del_timer_sync(&hc->keep_tl);
> > +	del_timer_sync(&hc->timeout_tl);
> > +	cancel_work_sync(&hc->workq);
> > +	del_timer_sync(&hc->keep_tl);
> >  	cancel_work_sync(&hc->workq);
> 
> Why not add a bit which will indicate that the device is shutting 
> down and check it in places which schedule the timer?
> I think that's much easier to reason about and we won't need to do 
> this rep cancel procedure.

Thank you for your time and suggestions!

Best regards,
Duoming Zhou