linux-kernel - Re: [PATCH 1/6] scsi: libsas: Add sas_task_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e264e099-8492-5ba5-ae66-4c71c146ba22@huawei.com>
Date:   Wed, 28 Sep 2022 14:50:01 +0100
From:   John Garry <john.garry@...wei.com>
To:     Jason Yan <yanaijie@...wei.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>, <jinpu.wang@...ud.ionos.com>,
        <damien.lemoal@....com>
CC:     <hare@...e.de>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>,
        <ipylypiv@...gle.com>, <changyuanl@...gle.com>, <hch@....de>
Subject: Re: [PATCH 1/6] scsi: libsas: Add sas_task_find_rq()

On 28/09/2022 14:13, Jason Yan wrote:
>> +++ b/include/scsi/libsas.h
>> @@ -644,6 +644,28 @@ static inline bool sas_is_internal_abort(struct 
>> sas_task *task)
>>       return task->task_proto == SAS_PROTOCOL_INTERNAL_ABORT;
>>   }
>> +static inline struct request *sas_task_find_rq(struct sas_task *task)
>> +{
>> +    struct scsi_cmnd *scmd;
>> +
>> +    if (!task || !task->uldd_task)
>> +        return NULL;
>> +
>> +    if (task->task_proto & SAS_PROTOCOL_STP_ALL) {
>> +        struct ata_queued_cmd *qc;
>> +
>> +        qc = task->uldd_task;
>> +        scmd = qc->scsicmd;
> 
> Can we remove that local qc?
>

We could...

> and
>      scmd = ((struct ata_queued_cmd *)task->uldd_task)->scsicmd;

... but I am not really sure that this is much better, specifically 
because of the casting from void. If you feel really strongly about it I 
could.

thanks,
John