linux-kernel - Re: [PATCH v6] hyperv: simplify and rename generate_guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzRSCSOIhHQ9JYmr@liuwe-devbox-debian-v2>
Date:   Wed, 28 Sep 2022 13:54:17 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Li kunyu <kunyu@...china.com>
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        wei.liu@...nel.org, decui@...rosoft.com, catalin.marinas@....com,
        will@...nel.org, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, dave.hansen@...ux.intel.com, hpa@...or.com,
        arnd@...db.de, x86@...nel.org, linux-hyperv@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arch@...r.kernel.org
Subject: Re: [PATCH v6] hyperv: simplify and rename generate_guest_id

On Wed, Sep 28, 2022 at 02:40:46PM +0800, Li kunyu wrote:
> The generate_guest_id function is more suitable for use after the
> following modifications.
> 1. The return value of the function is modified to u64.
> 2. Remove the d_info1 and d_info2 parameters from the function, keep the
> u64 type kernel_version parameter.
> 3. Rename the function to make it clearly a Hyper-V related function,
> and modify it to hv_generate_guest_id.
> 
> Signed-off-by: Li kunyu <kunyu@...china.com>
> 
> --------
>  v2: Fix generate_guest_id to hv_generate_guest_id.
>  v3: Fix [PATCH v2] asm-generic: Remove the ... to [PATCH v3] hyperv: simp
>      lify ... and remove extra spaces
>  v4: Remove #include <linux/version.h> in the calling file, and add #inclu
>      de <linux/version.h> in the function implementation file
>  v5: <linux/version.h> is changed to the definition position before v4, an
>      d the LINUX_VERSION_CODE macro is passed in the function call
>  v6: Modify the patch description information to the changed information a
>      fter discussion

This part -- normally the change history should be stripped when the
patch is committed with git-am(1).

The usual way of doing it is to place them (and any other text that is
not intended to be committed) after three dashes. No fewer, no more,
only three dashes.

Why three dashes? Git-am(1) has the following:

  The patch is expected to be inline, directly following the message. Any line that is of the
  form:

  •   three-dashes and end-of-line, or

  •   a line that begins with "diff -", or

  •   a line that begins with "Index: "

  is taken as the beginning of a patch, and the commit log message is terminated before the
  first occurrence of such a line.

Notice the last sentence. You used eight dashes. Git-am(1) does not
consider that pattern terminates the commit log message.

There is no need for you to do anything. I've cleaned up the commit
message and applied it to hyperv-next. I thought the above tidbit can
help you (or anyone else who doesn't know about this and happens to read
this lengthy email) in your future patch submission though. :-)

Thanks,
Wei.