linux-kernel - Re: [PATCH v15 2/4] trace/objtrace: Get the value of the object

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEr6+EAHVUntQMVAC0_Rm7A2wWWC9TZsYi4PgV-tdO0bvUKguA@mail.gmail.com>
Date:   Wed, 28 Sep 2022 22:15:24 +0800
From:   Jeff Xie <xiehuan09@...il.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     mingo@...hat.com, mhiramat@...nel.org, zanussi@...nel.org,
        linux-kernel@...r.kernel.org, chensong_2000@....cn
Subject: Re: [PATCH v15 2/4] trace/objtrace: Get the value of the object

On Mon, Sep 26, 2022 at 12:49 AM Jeff Xie <xiehuan09@...il.com> wrote:
>
> On Sun, Sep 25, 2022 at 11:53 PM Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> > On Sun, 25 Sep 2022 13:27:10 +0800
> > Jeff Xie <xiehuan09@...il.com> wrote:
> >
> > >
> > > It also looks like the "add" command field has been removed,
> > > Masami previously suggested I to add a reserved command field for the
> > > future (see [1] and [2]):
> > >
> > > [1]:
> > > https://lore.kernel.org/lkml/20211026225234.549ec8e9eb59f1fd1671edbc@kernel.org/
> > >
> > > [2]:
> > > https://lore.kernel.org/lkml/20211105004704.3f4aa456c2c537a56f64e65a@kernel.org/
> >
> > Ah, I see. add means enable the tracing and del means disable.
> >
> > Masami, perhaps we should call it "enable/disable" instead? Because, to
> > me "del" means to remove it (permanently), where as "enable/disable"
> > matches other triggers like the "enable/disable event" that starts and
> > stops another event.
> >
> > >
> > >
> > > > This code is available in the kprobe code that eprobes also uses:
> > > >
> > > > See process_fetch_insn() in kernel/trace/trace_eprobe.c
> > > >
> > > > and the parsing of the string is in kernel/trace/trace_probe.c:
> > > >
> > > >   parse_probe_arg()

I guess I won't be able to finish it until the next merge window, I've
been trying it for a few days
In my spare time recently, with no progress, it looks like it's really
more complicated to implement ;-)


> > >
> > > Thanks for your guidance, but the next merge window is coming soon,
> > > and since I'm not doing full-time kernel development,
> > > I can't guarantee that the development and testing of this change will
> > > be completed before the next window merge.
> > >
> > >  Anyone familiar with this code providing a patch is welcome ;-)
> >
> > If I get a chance, I may see if I can quickly implement it.
>
> Thanks a lot ;-)
>
> >
> > >
> > > >
> > > > I think doing this will make it much more extensive, not to mention it
> > > > will match the syntax of other code in the tracing infrastructure.
> > >
> > > I super agree.
> >
> > Thanks for you patience, and I'm sorry it took so long for me to review
> > it.
>
> Nevermind, I've always been a fan of ftrace.
>
> >
> > -- Steve
>
>
>
> --
> Thanks,
> JeffXie


-- 
Thanks,
JeffXie