linux-kernel - Re: [PATCH] mm: rmap: rename page_not_mapped() to folio_not

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ae48706e-e628-766e-8a74-e322b96eeb6b@redhat.com>
Date:   Wed, 28 Sep 2022 16:27:37 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org
Cc:     Matthew Wilcox <willy@...radead.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: rmap: rename page_not_mapped() to folio_not_mapped()

On 27.09.22 08:38, Kefeng Wang wrote:
> Since commit 2f031c6f042c ("mm/rmap: Convert rmap_walk() to
> take a folio"), page_not_mapped() takes folio as parameter,
> rename it to be consistent.
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> ---
>   mm/rmap.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/rmap.c b/mm/rmap.c
> index 2ec925e5fa6a..df228602cf0e 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -1801,7 +1801,7 @@ static bool invalid_migration_vma(struct vm_area_struct *vma, void *arg)
>   	return vma_is_temporary_stack(vma);
>   }
>   
> -static int page_not_mapped(struct folio *folio)
> +static int folio_not_mapped(struct folio *folio)
>   {
>   	return !folio_mapped(folio);
>   }
> @@ -1822,7 +1822,7 @@ void try_to_unmap(struct folio *folio, enum ttu_flags flags)
>   	struct rmap_walk_control rwc = {
>   		.rmap_one = try_to_unmap_one,
>   		.arg = (void *)flags,
> -		.done = page_not_mapped,
> +		.done = folio_not_mapped,
>   		.anon_lock = folio_lock_anon_vma_read,
>   	};
>   
> @@ -2150,7 +2150,7 @@ void try_to_migrate(struct folio *folio, enum ttu_flags flags)
>   	struct rmap_walk_control rwc = {
>   		.rmap_one = try_to_migrate_one,
>   		.arg = (void *)flags,
> -		.done = page_not_mapped,
> +		.done = folio_not_mapped,
>   		.anon_lock = folio_lock_anon_vma_read,
>   	};
>   
> @@ -2297,7 +2297,7 @@ static bool folio_make_device_exclusive(struct folio *folio,
>   	};
>   	struct rmap_walk_control rwc = {
>   		.rmap_one = page_make_device_exclusive_one,
> -		.done = page_not_mapped,
> +		.done = folio_not_mapped,
>   		.anon_lock = folio_lock_anon_vma_read,
>   		.arg = &args,
>   	};

I'm wondering if we should call it "folio_unmapped()". Anyhow

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb