linux-kernel - Re: [PATCH 6/6] perf stat: Don't compare runtime stat for shadow stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee88c7fa-67fa-1d96-1067-f0d87b96e653@arm.com>
Date:   Wed, 28 Sep 2022 15:52:15 +0100
From:   James Clark <james.clark@....com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-perf-users@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
        Kan Liang <kan.liang@...ux.intel.com>,
        Leo Yan <leo.yan@...aro.org>,
        Zhengjun Xing <zhengjun.xing@...ux.intel.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Jiri Olsa <jolsa@...nel.org>
Subject: Re: [PATCH 6/6] perf stat: Don't compare runtime stat for shadow
 stats



On 26/09/2022 21:07, Namhyung Kim wrote:
> Now it always uses the global rt_stat.  Let's get rid of the field from
> the saved_value.  When the both evsels are NULL, it'd return 0 so remove
> the block in the saved_value_cmp.
> 
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/util/stat-shadow.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
Reviewed-by: James Clark <james.clark@....com>

> diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c
> index 99d05262055c..700563306637 100644
> --- a/tools/perf/util/stat-shadow.c
> +++ b/tools/perf/util/stat-shadow.c
> @@ -35,7 +35,6 @@ struct saved_value {
>  	int ctx;
>  	int map_idx;
>  	struct cgroup *cgrp;
> -	struct runtime_stat *stat;
>  	struct stats stats;
>  	u64 metric_total;
>  	int metric_other;
> @@ -67,16 +66,6 @@ static int saved_value_cmp(struct rb_node *rb_node, const void *entry)
>  	if (a->cgrp != b->cgrp)
>  		return (char *)a->cgrp < (char *)b->cgrp ? -1 : +1;
>  
> -	if (a->evsel == NULL && b->evsel == NULL) {
> -		if (a->stat == b->stat)
> -			return 0;
> -
> -		if ((char *)a->stat < (char *)b->stat)
> -			return -1;
> -
> -		return 1;
> -	}
> -
>  	if (a->evsel == b->evsel)
>  		return 0;
>  	if ((char *)a->evsel < (char *)b->evsel)
> @@ -120,7 +109,6 @@ static struct saved_value *saved_value_lookup(struct evsel *evsel,
>  		.evsel = evsel,
>  		.type = type,
>  		.ctx = ctx,
> -		.stat = st,
>  		.cgrp = cgrp,
>  	};
>