linux-kernel - Re: [PATCH v5 1/9] dt-bindings: mfd: atmel,sama5d2-flexcom: Add SPI child node ref binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a0c45e2-85fc-b5b0-d1de-a9e06a20bb42@microchip.com>
Date:   Wed, 28 Sep 2022 15:07:37 +0000
From:   <Sergiu.Moga@...rochip.com>
To:     <lee@...nel.org>
CC:     <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
        <Claudiu.Beznea@...rochip.com>, <radu_nicolae.pirea@....ro>,
        <richard.genoud@...il.com>, <gregkh@...uxfoundation.org>,
        <jirislaby@...nel.org>, <Kavyasree.Kotagiri@...rochip.com>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-spi@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v5 1/9] dt-bindings: mfd: atmel,sama5d2-flexcom: Add SPI
 child node ref binding

On 28.09.2022 18:03, Lee Jones wrote:
> On Thu, 22 Sep 2022, Sergiu Moga wrote:
> 
>> Another functionality of FLEXCOM is that of SPI. In order for
>> the proper validation of the SPI children nodes through the binding
>> to occur, the proper binding for SPI must be referenced.
>>
>> Signed-off-by: Sergiu Moga <sergiu.moga@...rochip.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>>
>>
>> v1 -> v2:
>> - use full schema paths
>>
>>
>> v2 -> v3:
>> - Added Reviewed-by tag, previously this was [PATCH 3]
>>
>>
>> v3 -> v4:
>> - Nothing, previously this was [PATCH 5]
>>
>>
>> v4 -> v5:
>> - Nothing
>>
>>
>>
>>   .../devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml       | 5 ++---
>>   1 file changed, 2 insertions(+), 3 deletions(-)
> 
> Not sure how these can be handled.
> 
> I guess I cannot take these until the other patches are applied.
> 
> NB: The patch doesn't apply cleanly anyway, so will need to be rebased.
> 


Hello,

The sama5d2-flexcom binding related patches are dependent on:
https://lore.kernel.org/linux-arm-kernel/20220916075744.1879428-1-kavyasree.kotagiri@microchip.com/

as specified in the cover letter.

Regards,
	Sergiu


>> diff --git a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
>> index 0c80f4e98c54..f283cfd84b2d 100644
>> --- a/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
>> @@ -78,10 +78,9 @@ patternProperties:
>>         of USART bindings.
>>
>>     "^spi@[0-9a-f]+$":
>> -    type: object
>> +    $ref: /schemas/spi/atmel,at91rm9200-spi.yaml
>>       description:
>> -      Child node describing SPI. See ../spi/spi_atmel.txt for details
>> -      of SPI bindings.
>> +      Child node describing SPI.
>>
>>     "^i2c@[0-9a-f]+$":
>>       $ref: /schemas/i2c/atmel,at91sam-i2c.yaml
> 
> --
> Lee Jones [李琼斯]