linux-kernel - Re: [PATCH] dmaengine: qcom-adm: fix wrong calling convention for prep_slave

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YzXLcvv1eiRXzrND@matsya>
Date:   Thu, 29 Sep 2022 22:14:34 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Christian Marangi <ansuelsmth@...il.com>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Arnd Bergmann <arnd@...db.de>, Mark Brown <broonie@...nel.org>,
        Thomas Pedersen <twp@...eaurora.org>,
        Jonathan McDowell <noodles@...th.li>,
        linux-arm-msm@...r.kernel.org, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] dmaengine: qcom-adm: fix wrong calling convention for
 prep_slave_sg

On 16-09-22, 06:12, Christian Marangi wrote:
> The calling convention for pre_slave_sg is to return NULL on error and
> provide an error log to the system. Qcom-adm instead provide error
> pointer when an error occur. This indirectly cause kernel panic for
> example for the nandc driver that checks only if the pointer returned by
> device_prep_slave_sg is not NULL. Returning an error pointer makes nandc
> think the device_prep_slave_sg function correctly completed and makes
> the kernel panics later in the code.
> 
> While nandc is the one that makes the kernel crash, it was pointed out
> that the real problem is qcom-adm not following calling convention for
> that function.
> 
> To fix this, drop returning error pointer and return NULL with an error
> log.

Applied, thanks

-- 
~Vinod