linux-kernel - Re: [PATCH 2/2] perf tools: Remove unused variable in tests/test-basic.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzXfozrpDu0cm2am@kernel.org>
Date:   Thu, 29 Sep 2022 15:10:43 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Jiri Olsa <jolsa@...nel.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Ingo Molnar <mingo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Ian Rogers <irogers@...gle.com>,
        linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 2/2] perf tools: Remove unused variable in
 tests/test-basic.c

Em Thu, Sep 29, 2022 at 04:05:14PM +0200, Jiri Olsa escreveu:
> The clang 15 build reveal several unused-but-set variables,
> removing the 'foo' variable in tests/mmap-basic.o object.



Thanks, applied.

- Arnaldo

 
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---
>  tools/perf/tests/mmap-basic.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tools/perf/tests/mmap-basic.c b/tools/perf/tests/mmap-basic.c
> index 21b5e68179d7..8322fc2295fa 100644
> --- a/tools/perf/tests/mmap-basic.c
> +++ b/tools/perf/tests/mmap-basic.c
> @@ -112,8 +112,7 @@ static int test__basic_mmap(struct test_suite *test __maybe_unused, int subtest
>  
>  	for (i = 0; i < nsyscalls; ++i)
>  		for (j = 0; j < expected_nr_events[i]; ++j) {
> -			int foo = syscalls[i]();
> -			++foo;
> +			syscalls[i]();
>  		}
>  
>  	md = &evlist->mmap[0];
> -- 
> 2.37.3

-- 

- Arnaldo