lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 29 Sep 2022 13:27:19 -0600 From: Raul Rangel <rrangel@...omium.org> To: "Rafael J. Wysocki" <rafael@...nel.org> Cc: ACPI Devel Maling List <linux-acpi@...r.kernel.org>, linux-input <linux-input@...r.kernel.org>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Hans de Goede <hdegoede@...hat.com>, Mika Westerberg <mika.westerberg@...ux.intel.com>, Mario Limonciello <mario.limonciello@....com>, Tim Van Patten <timvp@...gle.com>, Linus Walleij <linus.walleij@...aro.org>, "jingle.wu" <jingle.wu@....com.tw>, Dan Williams <dan.j.williams@...el.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jonathan Cameron <Jonathan.Cameron@...wei.com>, Len Brown <lenb@...nel.org>, Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, Terry Bowman <terry.bowman@....com>, Tom Rix <trix@...hat.com>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, llvm@...ts.linux.dev Subject: Re: [PATCH v6 06/13] ACPI: resources: Add wake_capable parameter to acpi_dev_irq_flags On Thu, Sep 29, 2022 at 1:18 PM Rafael J. Wysocki <rafael@...nel.org> wrote: > > On Thu, Sep 29, 2022 at 6:19 PM Raul E Rangel <rrangel@...omium.org> wrote: > > > > ACPI IRQ/Interrupt resources contain a bit that describes if the > > interrupt should wake the system. This change exposes that bit via > > a new IORESOURCE_IRQ_WAKECAPABLE flag. Drivers should check this flag > > I would call this IORESOURCE_IRQ_WAKE which is (a) simpler and easier > to read and (b) it sort of matches the "wakeirq" naming convention. It was Dmitry who originally suggested the name. I personally like the CAPABLE in the name. It makes it clear that it's capable of acting as a wake source, not to be confused with being enabled as a wake source. > > This is not a big deal if you insist on this name and for a good > reason, but just something I would do differently. > > The patch LGTM otherwise. >
Powered by blists - more mailing lists