linux-kernel - Re: [PATCH v7 00/29] Rework the trip points creation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jrWamTTXcHabSk=6cmm4pEx0_ebiECKZRfrX_vS85YYg@mail.gmail.com>
Date:   Thu, 29 Sep 2022 21:35:48 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>,
        "Zhang, Rui" <rui.zhang@...el.com>,
        Raju Rangoju <rajur@...lsio.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Peter Kaestle <peter@...e.net>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Amit Kucheria <amitk@...nel.org>,
        Nicolas Saenz Julienne <nsaenz@...nel.org>,
        Broadcom Kernel Team <bcm-kernel-feedback-list@...adcom.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ray Jui <rjui@...adcom.com>,
        Scott Branden <sbranden@...adcom.com>,
        Support Opensource <support.opensource@...semi.com>,
        Lukasz Luba <lukasz.luba@....com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Niklas Söderlund <niklas.soderlund@...natech.se>,
        Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Eduardo Valentin <edubezval@...il.com>,
        Keerthy <j-keerthy@...com>,
        Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Antoine Tenart <atenart@...nel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Dmitry Osipenko <digetx@...il.com>,
        netdev <netdev@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        linux-rpi-kernel@...ts.infradead.org,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux Samsung SoC <linux-samsung-soc@...r.kernel.org>,
        linux-tegra <linux-tegra@...r.kernel.org>,
        Linux OMAP Mailing List <linux-omap@...r.kernel.org>
Subject: Re: [PATCH v7 00/29] Rework the trip points creation

On Thu, Sep 29, 2022 at 4:57 PM Daniel Lezcano
<daniel.lezcano@...aro.org> wrote:
>
> On 29/09/2022 15:58, Rafael J. Wysocki wrote:
> > On Thu, Sep 29, 2022 at 2:26 PM Daniel Lezcano
> > <daniel.lezcano@...aro.org> wrote:
> >>
> >>
> >> Hi Rafael,
> >>
> >> are you happy with the changes?
> >
> > I'll have a look and let you know.
>
> Great, thanks

Well, because you have not added the history of changes to the
patches, that will take more time than it would otherwise.

Generally, please always add information on what has changed in the
patch between different versions of it.

> >> I would like to integrate those changes with the thermal pull request
> >
> > Sure, but it looks like you've got only a few ACKs for these patches
> > from the driver people.
> >
> > Wouldn't it be prudent to give them some more time to review the changes?
>
> Well I would say I received the ACKs from the drivers which are actively
> maintained. Others are either not with a dedicated maintainer or not a
> reactive one. The first iteration of the series is from August 5th. So
> it has been 2 months.
>
> I pinged for imx, armada and tegra two weeks ago.

OK

> The st, hisilicon drivers fall under the thermal maintainers umbrella
>
> There are three series coming after this series to be posted. I would
> like to go forward in the process of cleaning up the framework. IMO two
> months is enough to let the maintainers pay attention to the changes,
> especially if we do a gentle ping and there are seven versions.
>
> And after that comes the thermal_zone_device_register() parameters
> simplification :)

Well, that's all fine, but I don't want people to get surprised by
significant changes they haven't expected and I want to avoid missing
anything subtle.