linux-kernel - Re: [PATCH] dt-bindings: samsung: soc: match preferred naming in entire compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220929212845.GA2725627-robh@kernel.org>
Date:   Thu, 29 Sep 2022 16:28:45 -0500
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Alim Akhtar <alim.akhtar@...sung.com>,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: samsung: soc: match preferred naming in
 entire compatible

On Mon, Sep 26, 2022 at 02:47:57PM +0200, Krzysztof Kozlowski wrote:
> Compatible is a string-array, therefore the "select" should look for
> anything containing Samsung SoC part.  This allows to validate cases
> like:
>  - "samsung,exynos5250-gsc", "samsung,exynos5-gsc"
>  - "samsung,exynos5250-pmu", "syscon"
>  - "tesla,fsd-mct", "samsung,exynos4210-mct"
> 
> Since Tesla FSD builts on top of Exynos blocks, add an adidtional
> pattern for it.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  .../bindings/arm/samsung/samsung-soc.yaml     | 26 +++++++++++++++----
>  1 file changed, 21 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-soc.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-soc.yaml
> index 653f85997643..bb1fdc205b44 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-soc.yaml
> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-soc.yaml
> @@ -18,17 +18,33 @@ description: |
>      samsung,exynos5433-cmu-isp
>  
>  select:
> -  properties:
> -    compatible:
> -      pattern: "^samsung,.*(s3c|s5pv|exynos)[0-9a-z]+.*$"
> +  allOf:
> +    - properties:
> +        $nodename:
> +          pattern: '^[a-z]'

Why do you need this?

> +    - properties:
> +        compatible:
> +          contains:
> +            pattern: "^samsung,.*(s3c|s5pv|exynos)[0-9a-z]+.*$"
>    required:
>      - compatible
>  
>  properties:
>    compatible:
>      oneOf:
> -      - description: Preferred naming style for compatibles of SoC components
> -        pattern: "^samsung,(s3c|s5pv|exynos|exynosautov)[0-9]+-.*$"
> +      - description: Preferred naming style for compatibles of S3C/S5P/Exynos SoC components
> +        minItems: 1
> +        items:
> +          - pattern: "^samsung,(s3c|s5pv|exynos|exynosautov)[0-9]+-.*$"
> +          - {}
> +          - {}

Wouldn't just contains be fine here too:

contains:
  pattern: "^samsung,(s3c|s5pv|exynos|exynosautov)[0-9]+-.*$"

> +
> +      - description: Preferred naming style for compatibles of Tesla FSD SoC components
> +        minItems: 1
> +        items:
> +          - pattern: "^tesla,fsd-.*$"
> +          - {}
> +          - {}
>  
>        # Legacy compatibles with wild-cards - list cannot grow with new bindings:
>        - enum:
> -- 
> 2.34.1
> 
>