linux-kernel - Re: [PATCH] binfmt: remove taso from linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tu4p3jwn.fsf@email.froward.int.ebiederm.org>
Date:   Thu, 29 Sep 2022 17:17:28 -0500
From:   "Eric W. Biederman" <ebiederm@...ssion.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Kees Cook <keescook@...omium.org>, linux-mm@...ck.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] binfmt: remove taso from linux_binprm struct

Lukas Bulwahn <lukas.bulwahn@...il.com> writes:

> With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the
> use of the special taso flag for alpha architectures in the linux_binprm
> struct is gone.
>
> Remove the definition of taso in the linux_binprm struct.
>
> No functional change.

Reviewed-by: "Eric W. Biederman" <ebiederm@...ssion.com>

Alphas binfmt_loader is the only use I can find of that variable
so let's kill it as well.

> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
> Kees, please pick this patch on top of the commit above.
>
>  include/linux/binfmts.h | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/include/linux/binfmts.h b/include/linux/binfmts.h
> index 3dc20c4f394c..8d51f69f9f5e 100644
> --- a/include/linux/binfmts.h
> +++ b/include/linux/binfmts.h
> @@ -43,9 +43,6 @@ struct linux_binprm {
>  		 * original userspace.
>  		 */
>  		point_of_no_return:1;
> -#ifdef __alpha__
> -	unsigned int taso:1;
> -#endif
>  	struct file *executable; /* Executable to pass to the interpreter */
>  	struct file *interpreter;
>  	struct file *file;