linux-kernel - Re: [PATCH 1/1] usb: gadget: tegra-xudc: Add Tegra234 SOC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR12MB55006EF3D20D3A85062FAF85AF579@PH0PR12MB5500.namprd12.prod.outlook.com>
Date:   Thu, 29 Sep 2022 03:46:41 +0000
From:   Wayne Chang <waynec@...dia.com>
To:     Jonathan Hunter <jonathanh@...dia.com>,
        "balbi@...nel.org" <balbi@...nel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "thierry.reding@...il.com" <thierry.reding@...il.com>
CC:     Sing-Han Chen <singhanc@...dia.com>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] usb: gadget: tegra-xudc: Add Tegra234 SOC support

Hi Jonathan,

Thanks for the review.

On 9/29/22 03:04, Jonathan Hunter wrote:
> 
> On 28/09/2022 14:55, Wayne Chang wrote:
>> From: Sing-Han Chen <singhanc@...dia.com>
>>
>> This commit adds XUSB device mode controller support on Tegra234 SoC.
>> Tegra234 XUDC is very similar to the existing Tegra194 XUDC.
>>
>> Signed-off-by: Sing-Han Chen <singhanc@...dia.com>
>> Signed-off-by: Wayne Chang <waynec@...dia.com>
>> ---
>>    drivers/usb/gadget/udc/tegra-xudc.c | 17 +++++++++++++++++
>>    1 file changed, 17 insertions(+)
>>
>> diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
>> index 3c37effdfa64..53277aa5a270 100644
>> --- a/drivers/usb/gadget/udc/tegra-xudc.c
>> +++ b/drivers/usb/gadget/udc/tegra-xudc.c
>> @@ -3656,6 +3656,19 @@ static struct tegra_xudc_soc tegra194_xudc_soc_data = {
>>    	.has_ipfs = false,
>>    };
>>    
>> +static struct tegra_xudc_soc tegra234_xudc_soc_data = {
>> +	.clock_names = tegra186_xudc_clock_names,
>> +	.num_clks = ARRAY_SIZE(tegra186_xudc_clock_names),
>> +	.num_phys = 4,
>> +	.u1_enable = true,
>> +	.u2_enable = true,
>> +	.lpm_enable = true,
>> +	.invalid_seq_num = false,
>> +	.pls_quirk = false,
>> +	.port_reset_quirk = false,
>> +	.has_ipfs = false,
>> +};
>> +
>>    static const struct of_device_id tegra_xudc_of_match[] = {
>>    	{
>>    		.compatible = "nvidia,tegra210-xudc",
>> @@ -3669,6 +3682,10 @@ static const struct of_device_id tegra_xudc_of_match[] = {
>>    		.compatible = "nvidia,tegra194-xudc",
>>    		.data = &tegra194_xudc_soc_data
>>    	},
>> +	{
>> +		.compatible = "nvidia,tegra234-xudc",
>> +		.data = &tegra234_xudc_soc_data
>> +	},
> 
> 
> The device-tree binding documentation is missing for this compatible
> string. Please send a patch to add this compatible string to the
> appropriate binding doc.
Thanks. Sent out the change to add the compatible string to xudc binding 
doc.

https://lore.kernel.org/all/20220929034221.3817058-1-waynec@nvidia.com/T/#u

> 
> Thanks!
> Jon
> 

thanks,
Wayne.