linux-kernel - Re: [PATCH 2/2] phy: mediatek: tphy: add debugfs files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Sep 2022 14:12:23 +0800
From:   Chunfeng Yun <chunfeng.yun@...iatek.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Vinod Koul <vkoul@...nel.org>
CC:     Kishon Vijay Abraham I <kishon@...com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-phy@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        Eddie Hung <eddie.hung@...iatek.com>,
        Tianping Fang <tianping.fang@...iatek.com>
Subject: Re: [PATCH 2/2] phy: mediatek: tphy: add debugfs files

On Wed, 2022-09-28 at 15:35 +0200, AngeloGioacchino Del Regno wrote:
> Il 28/09/22 11:30, Chunfeng Yun ha scritto:
> > These debugfs files are mainly used to make eye diagram test
> > easier,
> > especially helpful to do HQA test for a new IC without efuse
> > enabled.
> > 
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@...iatek.com>
> 
> Even though this won't be interesting for the vast majority of the
> people
> out there (the users!), it's still nice to have it for IC testing
> performed
> directly on upstream, as that opens new possibilities for you and
> ODMs/OEMs,
> so I agree on getting that code upstreamed.
> 
> For that reason, I think that the best approach for this one would be
> to
> enclose it in a configuration option like CONFIG_PHY_MTK_TPHY_DEBUGFS
> or
> CONFIG_PHY_MTK_TPHY_DEBUG, so that this very low level debugging code
> doesn't end up in end-user builds, as that may, in some cases, be
> even
> dangerous.
Yes, It seems better, I'll modify it, thanks a lot

> 
> Regards,
> Angelo
>