linux-kernel - Re: [PATCH net-next 1/2] nfc: s3fwrn5: fix order of freeing resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <26fd03ad-181c-97c5-f620-6ac296cf1829@linaro.org>
Date:   Thu, 29 Sep 2022 09:27:19 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Krzysztof Opasiak <k.opasiak@...sung.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] nfc: s3fwrn5: fix order of freeing resources

On 29/09/2022 09:26, Krzysztof Kozlowski wrote:
> On 29/09/2022 07:04, Dmitry Torokhov wrote:
>> Caution needs to be exercised when mixing together regular and managed
>> resources. In case of this driver devm_request_threaded_irq() should
>> not be used, because it will result in the interrupt being freed too
>> late, and there being a chance that it fires up at an inopportune
>> moment and reference already freed data structures.
> 
> Non-devm was so far recommended only for IRQF_SHARED, not for regular
> ones. Otherwise you have to fix half of Linux kernel drivers... why is
> s3fwrn5 special?
> 


> Please use scripts/get_maintainers.pl to Cc also netdev folks.

Ah, they are not printed for NFC drivers. So never mind last comment.

Best regards,
Krzysztof