linux-kernel - Re: [PATCH RESEND v2 2/5] clk: mxl: Remove unnecessary spinlocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220929001606.02029C433B5@smtp.kernel.org>
Date:   Wed, 28 Sep 2022 17:16:02 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Rahul Tanwar <rtanwar@...linear.com>, linux-clk@...r.kernel.org,
        mturquette@...libre.com
Cc:     linux-kernel@...r.kernel.org, linux-lgm-soc@...linear.com,
        Rahul Tanwar <rtanwar@...linear.com>
Subject: Re: [PATCH RESEND v2 2/5] clk: mxl: Remove unnecessary spinlocks

Quoting Rahul Tanwar (2022-09-21 23:24:25)
> This driver is now switched from direct readl/writel based register
> access to regmap based register acceess. Regmap already has its own
> lock to serialize the register accesses across multiple cores.
> 
> Hence, there is no need for additional spinlocks in the driver.
> Remove all spinlocks which are no longer required.

Can you confirm that the driver doesn't do a read, modify, write (rmw)
sequence where during the modification another CPU can rmw and corrupt
the previous "read"?