linux-kernel - Re: [PATCH -resend v2] clk: pistachio: Fix initconst confusion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220929013505.81B0AC433D6@smtp.kernel.org>
Date:   Wed, 28 Sep 2022 18:35:03 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Jiri Slaby <jslaby@...e.cz>, mturquette@...libre.com
Cc:     linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
        linux-clk@...r.kernel.org, Martin Liska <mliska@...e.cz>,
        Jiri Slaby <jslaby@...e.cz>
Subject: Re: [PATCH -resend v2] clk: pistachio: Fix initconst confusion

Quoting Jiri Slaby (2022-09-19 22:58:38)
> From: Andi Kleen <ak@...ux.intel.com>
> 
> A variable pointing to const isn't const itself. It has to contain
> "const" keyword after "*" too. So to keep it in __initconst (and not
> mark properly as __initdata), add the "const" keyword exactly there.
> 
> Note we need to update struct pistachio_mux too. On the other hand, the
> clk core already counts with "const char *const" already.
> 
> [js] more explanatory commit message.
> 
> Cc: Michael Turquette <mturquette@...libre.com>
> Cc: Stephen Boyd <sboyd@...nel.org>
> Cc: linux-clk@...r.kernel.org
> Cc: Martin Liska <mliska@...e.cz>
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> ---

Applied to clk-next