linux-kernel - Re: [PATCH v2 2/2] Documentation/process: Add text to indicate supporters should be mailed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a9bd8038-255b-eb2c-babf-db329981f5d5@linaro.org>
Date:   Thu, 29 Sep 2022 11:52:05 +0100
From:   Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        corbet@....net, linux@...mhuis.info,
        konstantin@...uxfoundation.org, linux-doc@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] Documentation/process: Add text to indicate
 supporters should be mailed

On 29/09/2022 08:29, Krzysztof Kozlowski wrote:
> On 29/09/2022 02:25, Bryan O'Donoghue wrote:
>> Recently when submitting a yaml change I found that I had omitted the
>> maintainer whose tree the change needed to go through.
>>
>> The reason for that is the path in MAINTAINERS is marked as Supported not
>> Maintained. Reading MAINTAINERS we see quote:
>>
>>             Supported:   Someone is actually paid to look after this.
>>             Maintained:  Someone actually looks after it.
>>
>> The current submitting-patches.rst only says to mail maintainers though not
>> supporters. When we run scripts/get_maintainer.pl anybody who is denoted a
>> paid maintainer will appear as a supporter.
>>
>> Let's add some text to the submitting-patches.rst to indicate that
>> supporters should similarly be mailed so that you can't do as I did and
>> mail every maintainer get_maintainer.pl tells you to, without actually
>> mailing the one supporter you need to.
>>
>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
>> ---
>>   Documentation/process/submitting-patches.rst | 8 +++++---
>>   1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/process/submitting-patches.rst b/Documentation/process/submitting-patches.rst
>> index be49d8f2601b4..aabccaea93375 100644
>> --- a/Documentation/process/submitting-patches.rst
>> +++ b/Documentation/process/submitting-patches.rst
>> @@ -227,9 +227,11 @@ You should always copy the appropriate subsystem maintainer(s) on any patch
>>   to code that they maintain; look through the MAINTAINERS file and the
>>   source code revision history to see who those maintainers are.  The
>>   script scripts/get_maintainer.pl can be very useful at this step (pass paths to
>> -your patches as arguments to scripts/get_maintainer.pl).  If you cannot find a
>> -maintainer for the subsystem you are working on, Andrew Morton
>> -(akpm@...ux-foundation.org) serves as a maintainer of last resort.
>> +your patches as arguments to scripts/get_maintainer.pl).  You should mail
>> +everyone who appears as "maintainer[volunteer]" or "maintainer[supporter]" as
> 
> As I said before, this still ignores reviewers. I don't think it is
> going to good direction. The submitter is expected to CC
> everyone/everything which is pointed by get_maintainers.pl except the
> Git-fallback entries.


I just found the --nogit-fallback option which produces:

scripts/get_maintainer.pl Documentation/process/submitting-patches.rst
Jonathan Corbet <corbet@....net> 
(maintainer:DOCUMENTATION,commit_signer:10/12=83%)
Konstantin Ryabitsev <konstantin@...uxfoundation.org> 
(commit_signer:2/12=17%)
Thorsten Leemhuis <linux@...mhuis.info> 
(commit_signer:2/12=17%,authored:2/12=17%,added_lines:24/46=52%,removed_lines:13/67=19%)
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> 
(commit_signer:2/12=17%,authored:2/12=17%,added_lines:8/46=17%,removed_lines:4/67=6%)
Randy Dunlap <rdunlap@...radead.org> (commit_signer:2/12=17%)
"Bryan O'Donoghue" <bryan.odonoghue@...aro.org> 
(authored:1/12=8%,added_lines:5/46=11%)
Erik Ekman <erik@...o.se> (authored:1/12=8%)
Mauro Carvalho Chehab <mchehab+huawei@...nel.org> (authored:1/12=8%)
Jiri Kosina <jkosina@...e.cz> (removed_lines:20/67=30%)
Miguel Ojeda <ojeda@...nel.org> (removed_lines:19/67=28%)
linux-doc@...r.kernel.org (open list:DOCUMENTATION)
linux-kernel@...r.kernel.org (open list)

scripts/get_maintainer.pl --status --nom --nol --nogit --nogit-fallback 
-f Documentation/process/submitting-patches.rst

How about something like "send email to every mail address produced by 
scripts/get_maintainer.pl $filename but consider linux-kernel optional 
when sending subsystem specific patches"

---
bod