linux-kernel - Re: [PATCH 2/3] arm64: module: Remove unused plt_entry_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YzWBQym0PtExhZH9@FVFF77S0Q05N>
Date:   Thu, 29 Sep 2022 12:28:03 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Li Huafei <lihuafei1@...wei.com>
Cc:     catalin.marinas@....com, will@...nel.org, rostedt@...dmis.org,
        mingo@...hat.com, Julia.Lawall@...ia.fr, akpm@...ux-foundation.org,
        andreyknvl@...il.com, elver@...gle.com, wangkefeng.wang@...wei.com,
        zhouchengming@...edance.com, ardb@...nel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] arm64: module: Remove unused
 plt_entry_is_initialized()

On Thu, Sep 29, 2022 at 05:41:33PM +0800, Li Huafei wrote:
> Since commit f1a54ae9af0d ("arm64: module/ftrace: intialize PLT at load
> time"), plt_entry_is_initialized() is unused anymore , so remove it.
> 
> Signed-off-by: Li Huafei <lihuafei1@...wei.com>

Acked-by: Mark Rutland <mark.rutland@....com>

Mark.

> ---
>  arch/arm64/include/asm/module.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/arch/arm64/include/asm/module.h b/arch/arm64/include/asm/module.h
> index 28514b989a0b..8096d30c5e39 100644
> --- a/arch/arm64/include/asm/module.h
> +++ b/arch/arm64/include/asm/module.h
> @@ -59,9 +59,4 @@ static inline bool is_forbidden_offset_for_adrp(void *place)
>  
>  struct plt_entry get_plt_entry(u64 dst, void *pc);
>  
> -static inline bool plt_entry_is_initialized(const struct plt_entry *e)
> -{
> -	return e->adrp || e->add || e->br;
> -}
> -
>  #endif /* __ASM_MODULE_H */
> -- 
> 2.17.1
>