linux-kernel - Re: [PATCH v2 1/2] dt-bindings: clock: Add bindings for Renesas ProXO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Sep 2022 14:00:50 +0200
From:   Michal Simek <michal.simek@....com>
To:     Stephen Boyd <sboyd@...nel.org>,
        Alex Helms <alexander.helms.jy@...esas.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
CC:     Rob Herring <robh@...nel.org>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <mturquette@...libre.com>, <geert+renesas@...der.be>
Subject: Re: [PATCH v2 1/2] dt-bindings: clock: Add bindings for Renesas ProXO

On 9/29/22 01:41, Stephen Boyd wrote:
> Quoting Alex Helms (2022-09-28 16:16:04)
>> On 9/27/2022 7:51 AM, Geert Uytterhoeven wrote:
>>> Hi Michal,
>>>
>>> On Tue, Sep 27, 2022 at 4:10 PM Michal Simek <michal.simek@....com> wrote:
>>>> On 9/27/22 01:04, Rob Herring wrote:
>>>>> On Fri, Sep 23, 2022 at 01:52:50PM -0700, Alex Helms wrote:
>>>>>> Add dt bindings for the Renesas ProXO oscillator.
>>>>>>
>>>>>> Signed-off-by: Alex Helms <alexander.helms.jy@...esas.com>
>>>
>>>>>> --- /dev/null
>>>>>> +++ b/Documentation/devicetree/bindings/clock/renesas,proxo.yaml
>>>
>>>> Driver is also using clock-output-names which is not listed here.
>>>
>>> ... which is deprecated, and thus should not be used by the driver
>>> at all.
>>
>> Can you point me to somewhere showing it is deprecated? It is in the
>> current dt clock documentation.
>>
> 
> I wouldn't say it is deprecated. Instead, it isn't useful if you're able
> to use struct clk_parent_data and auto-generated clk names.

I am not closely doing clk subsystem but these chips are clock provider without 
any parent. If you mean calling function like this 
of_clk_get_parent_name(client->dev.of_node, 0) then it should return null.
But maybe there is something else what you are referring to.

I see that fixed clock driver is using node->name which is also problematic 
because node name for these devices on i2c will look like clock-controller@XX
where XX could be the same when i2c muxes are used.

And in connection to deprecation. I see only one file which is saying that it is 
deprecated.
Documentation/devicetree/bindings/sound/samsung-i2s.yaml
and it was deprecated before yaml conversion already.

Thanks,
Michal