linux-kernel - Re: [PATCH v1 5/7] arm: dts: qcom: mdm9615: remove invalid pmic subnodes compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Sep 2022 14:48:39 +0200
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v1 5/7] arm: dts: qcom: mdm9615: remove invalid pmic
 subnodes compatibles

Hi,

On 29/09/2022 14:27, Krzysztof Kozlowski wrote:
> 
> We are making circles and discussion takes too much. 

I'm sorry this happens, but I really want solve this stuff which in suspend since 2015.

So let me recall the original issue:

DTBS check reports:

arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dtb: pmic@0: compatible: ['qcom,pm8018', 'qcom,pm8921'] is too long
         From schema: Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml

arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dtb: pmic@0: rtc@11d:compatible: ['qcom,pm8018-rtc', 'qcom,pm8921-rtc'] is too long
         From schema: Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml

arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dtb:0:0: /soc/qcom,ssbi@...000/pmic@...wrkey@1c: failed to match any schema with compatible: ['qcom,pm8018-pwrkey', 'qcom,pm8921-pwrkey']

arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dtb:0:0: /soc/qcom,ssbi@...000/pmic@...wrkey@1c: failed to match any schema with compatible: ['qcom,pm8018-pwrkey', 'qcom,pm8921-pwrkey']

arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dtb: rtc@11d: compatible: ['qcom,pm8018-rtc', 'qcom,pm8921-rtc'] is too long
         From schema: Documentation/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml

So trying to solve those, and since the PMIC in the wp8548 module is a PM8018, and it happens to be (partially ?? potentially ??) compatible
with the PM8921, and I had issues adding per-HW compatible for the pwrkey, the obvious solution would be to
drop the PM8921 compatibility since it's only probable and nothing proves it's right.

But what's sure: it's a PM8018 PMIC.

But since the PM8018 PWRKEY interface is compatible with the PM8921 PWRKEY interface,
it's perfectly ok to the the MP8921 compatible here.

OK, so as you quoted multiple times:
"How this should be fixed? First, drop bogus entries from drivers, then
document proper compatibles."

OK so there's no bogus entries to remove here, and the only compatible to
potentially document is the pm8018-pwrkey but it seems to be wrong.

I'll be happy to have an hint on how to handle that to I can go forward and
stop the noise, there's still plenty of stuff to fix in the MDM9615 DT.

> 
> Best regards,
> Krzysztof
> 

Thanks,
Neil