linux-kernel - Re: [PATCH v2] Documentation: Kunit: Use full path to .kunitconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af104afb-7273-bdb9-9f8f-9f5c80fd2f7c@gmail.com>
Date:   Thu, 29 Sep 2022 19:57:59 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Khalid Masum <khalid.masum.92@...il.com>,
        Brendan Higgins <brendan.higgins@...ux.dev>,
        David Gow <davidgow@...gle.com>,
        Jonathan Corbet <corbet@....net>,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Sadiya Kazi <sadiyakazi@...gle.com>
Subject: Re: [PATCH v2] Documentation: Kunit: Use full path to .kunitconfig

On 9/29/22 15:53, Khalid Masum wrote:
> The fourth list item on writing test cases instructs adding Kconfig
> fragments to .kunitconfig, which should have been full path to the file
> (.kunit/.kunitconfig).
> 
> Cc: Sadiya Kazi <sadiyakazi@...gle.com>
> Cc: David Gow <davidgow@...gle.com>
> Suggested-by: Bagas Sanjaya <bagasdotme@...il.com>
> Signed-off-by: Khalid Masum <khalid.masum.92@...il.com>
> ---
> Changes since v1:
> - Update commit message
> - Make the instruction more descriptive
> 
>  Documentation/dev-tools/kunit/start.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/dev-tools/kunit/start.rst b/Documentation/dev-tools/kunit/start.rst
> index 867a4bba6bf6..69361065cda6 100644
> --- a/Documentation/dev-tools/kunit/start.rst
> +++ b/Documentation/dev-tools/kunit/start.rst
> @@ -217,7 +217,7 @@ Now we are ready to write the test cases.
>  
>  	obj-$(CONFIG_MISC_EXAMPLE_TEST) += example_test.o
>  
> -4. Add the following lines to ``.kunitconfig``:
> +4. Add following configuration fragments to ``.kunit/.kunitconfig``:
>  
>  .. code-block:: none
>  

Looks OK, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@...il.com>

-- 
An old man doll... just what I always wanted! - Clara