linux-kernel - Re: [PATCH] binfmt: remove taso from linux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87wn9kzup1.fsf@email.froward.int.ebiederm.org>
Date:   Fri, 30 Sep 2022 11:35:38 -0500
From:   "Eric W. Biederman" <ebiederm@...ssion.com>
To:     Kees Cook <keescook@...omium.org>
Cc:     Lukas Bulwahn <lukas.bulwahn@...il.com>, linux-mm@...ck.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] binfmt: remove taso from linux_binprm struct

Kees Cook <keescook@...omium.org> writes:

> On Thu, Sep 29, 2022 at 05:17:28PM -0500, Eric W. Biederman wrote:
>> Lukas Bulwahn <lukas.bulwahn@...il.com> writes:
>> 
>> > With commit 987f20a9dcce ("a.out: Remove the a.out implementation"), the
>> > use of the special taso flag for alpha architectures in the linux_binprm
>> > struct is gone.
>> >
>> > Remove the definition of taso in the linux_binprm struct.
>> >
>> > No functional change.
>> 
>> Reviewed-by: "Eric W. Biederman" <ebiederm@...ssion.com>
>> 
>> Alphas binfmt_loader is the only use I can find of that variable
>> so let's kill it as well.
>
> Ah, sorry, misparsed this -- you mean, alpha's use (now removed) was the
> only place it was accessed. Agreed. :)

Yes.  I was looking in a tree without my previous change merged.

The code in binfmt_loader (which is removed in the my change) was the
only user of that variable I could find.

Eric