linux-kernel - Re: [PATCH 1/3] audit: cache ctx->major in audit_filter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHC9VhR2AL9o6SKXW9xNJo5PW6T0CdTxbh8sy5OgE0ifY29RAg@mail.gmail.com>
Date:   Fri, 30 Sep 2022 14:22:53 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Ankur Arora <ankur.a.arora@...cle.com>
Cc:     linux-audit@...hat.com, boris.ostrovsky@...cle.com,
        linux-kernel@...r.kernel.org, eparis@...hat.com,
        konrad.wilk@...cle.com, Steve Grubb <sgrubb@...hat.com>
Subject: Re: [PATCH 1/3] audit: cache ctx->major in audit_filter_syscall()

On Fri, Sep 30, 2022 at 1:45 PM Steve Grubb <sgrubb@...hat.com> wrote:
> Hello,
>
> Thanks for the detailed notes on this investigation. It really is  a lot of
> good information backing this up. However, there will come a day when someone
> sees this "major = ctx->major" and they will send a patch to "fix" this
> unnecessary assignment. If you are sending a V2 of this set, I would suggest
> adding some comment in the code that this is for a performance improvement
> and to see the commit message for additional info.

Please do not send a v2 with the changes Steve is suggesting, I think
this patch is fine as-is.

-- 
paul-moore.com