linux-kernel - Re: [PATCH] ext4: Register ext[23] support only after successful ext4 registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.WNT.2.20.2209292143240.4648@CLUIJ>
Date:   Thu, 29 Sep 2022 21:45:04 -0600 (Mountain Daylight Time)
From:   Marc Aurèle La France <tsi@...oix.net>
To:     "Theodore Ts'o" <tytso@....edu>
cc:     Andreas Dilger <adilger.kernel@...ger.ca>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: Register ext[23] support only after successful
 ext4 registration

On Thu, 29 Sep 2022, Theodore Ts'o wrote:
> On Wed, Aug 10, 2022 at 02:20:45PM -0600, Marc Aurèle La France wrote:
>> Register ext4 as a "replacement" for ext2 and ext3 only after ext4 itself has
>> been successfully registered.  As a side effect, this allows
>> unregister_as_ext[23]() to be inlined.

> The corrent ordering is deliberate; it allows file systems that have
> ext2 and ext3 only file system features will be reported as using ext2
> and ext3 in /proc/mounts.  This doesn't matter quite as much, but it
> could potentially break userspace if a legacy file system that only
> has ext2 file system features is mounted and reported as ext4.

> So sorry, I can't take this change.

Fair enough.  Thanks for responding.

Marc.