linux-kernel - Re: [PATCH 1/3] tpm: st33zp24: drop support for platform data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Sep 2022 23:39:06 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] tpm: st33zp24: drop support for platform data

On Sun, Sep 25, 2022 at 10:39:56PM -0700, Dmitry Torokhov wrote:
> There are no users of st33zp24_platform_data in mainline, and new boards
> should be using device tree or ACPI to describe resources, so let's drop
> support for platform data from the driver.

Nit: drop instead of let's drop (needs also different sentence structure
obviously).

Also, please leave predictions out, or back them up with data. It's good
enough reason to remove code, if it is not used for anything. I really
don't care about "should" part. It is is out-of-scope for a kernel
patch.

BR, Jarkko