lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YzdVJYuzYzBTELI0@kernel.org>
Date:   Fri, 30 Sep 2022 23:44:21 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] tpm: st33zp24: remove pointless checks on probe

On Sun, Sep 25, 2022 at 10:39:58PM -0700, Dmitry Torokhov wrote:
> Driver core will never call driver's probe method without appropriate
> device structure, so testing them for NULL is pointless.
> 
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>

Missing a description what the patch does.

Also instead of "driver's probe method" you could just use
"st33zp24_i2c_probe()". It's even shorter.

BR, Jarkko

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ