linux-kernel - [ammarfaizi2-block:kvalo/ath/ath12k-bringup 31/61] drivers/net/wireless/ath/ath12k/dp_tx.c:1198:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 1 Oct 2022 04:54:45 +0800
From:   kernel test robot <lkp@...el.com>
To:     Pradeep Kumar Chitrapu <quic_pradeepc@...cinc.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Ammar Faizi <ammarfaizi2@...weeb.org>,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org, Kalle Valo <quic_kvalo@...cinc.com>
Subject: [ammarfaizi2-block:kvalo/ath/ath12k-bringup 31/61]
 drivers/net/wireless/ath/ath12k/dp_tx.c:1198:6: warning: variable 'ret' is
 used uninitialized whenever 'if' condition is false

tree:   https://github.com/ammarfaizi2/linux-block kvalo/ath/ath12k-bringup
head:   b7359c7cbbd54850f824f724774c41997668b803
commit: 3936b1ff26d1956e5bbb998f843053f3edb0f042 [31/61] wifi: ath12k: fix initializations in dp_tx.c
config: i386-allmodconfig
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/3936b1ff26d1956e5bbb998f843053f3edb0f042
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block kvalo/ath/ath12k-bringup
        git checkout 3936b1ff26d1956e5bbb998f843053f3edb0f042
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/gpu/ drivers/net/ samples/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/net/wireless/ath/ath12k/dp_tx.c:1198:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
           if (ab->hw_params->rxdma1_enable) {
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/ath12k/dp_tx.c:1210:9: note: uninitialized use occurs here
           return ret;
                  ^~~
   drivers/net/wireless/ath/ath12k/dp_tx.c:1198:2: note: remove the 'if' if its condition is always true
           if (ab->hw_params->rxdma1_enable) {
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/ath/ath12k/dp_tx.c:1190:9: note: initialize the variable 'ret' to silence this warning
           int ret, ring_id;
                  ^
                   = 0
   1 warning generated.


vim +1198 drivers/net/wireless/ath/ath12k/dp_tx.c

f40abb4788a2a3 Vasanthakumar Thiagarajan 2022-02-01  1184  
f40abb4788a2a3 Vasanthakumar Thiagarajan 2022-02-01  1185  int ath12k_dp_tx_htt_tx_monitor_mode_ring_config(struct ath12k *ar, bool reset)
f40abb4788a2a3 Vasanthakumar Thiagarajan 2022-02-01  1186  {
f40abb4788a2a3 Vasanthakumar Thiagarajan 2022-02-01  1187  	struct ath12k_base *ab = ar->ab;
f40abb4788a2a3 Vasanthakumar Thiagarajan 2022-02-01  1188  	struct ath12k_dp *dp = &ab->dp;
f40abb4788a2a3 Vasanthakumar Thiagarajan 2022-02-01  1189  	struct htt_tx_ring_tlv_filter tlv_filter = {0};
3936b1ff26d195 Pradeep Kumar Chitrapu    2022-09-20  1190  	int ret, ring_id;
f40abb4788a2a3 Vasanthakumar Thiagarajan 2022-02-01  1191  
f40abb4788a2a3 Vasanthakumar Thiagarajan 2022-02-01  1192  	ring_id = dp->tx_mon_buf_ring.refill_buf_ring.ring_id;
f40abb4788a2a3 Vasanthakumar Thiagarajan 2022-02-01  1193  
f40abb4788a2a3 Vasanthakumar Thiagarajan 2022-02-01  1194  	/* TODO: Need to set upstream/downstream tlv filters
f40abb4788a2a3 Vasanthakumar Thiagarajan 2022-02-01  1195  	 * here
f40abb4788a2a3 Vasanthakumar Thiagarajan 2022-02-01  1196  	 */
f40abb4788a2a3 Vasanthakumar Thiagarajan 2022-02-01  1197  
0cf4a34c762040 Kalle Valo                2022-07-01 @1198  	if (ab->hw_params->rxdma1_enable) {

:::::: The code at line 1198 was first introduced by commit
:::::: 0cf4a34c762040fce4480ded01c3f6b917f9ab05 ath12k: convert hw_params to a const pointer

:::::: TO: Kalle Valo <quic_kvalo@...cinc.com>
:::::: CC: Kalle Valo <quic_kvalo@...cinc.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (278710 bytes)