linux-kernel - Re: [PATCH] crypto: tcrypt - fix return value for multiple subtests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab0d9840-07e3-ec49-a9b3-c4b65d7d61bc@intel.com>
Date:   Fri, 30 Sep 2022 15:09:34 -0700
From:   Anirudh Venkataramanan <anirudh.venkataramanan@...el.com>
To:     Robert Elliott <elliott@....com>, <herbert@...dor.apana.org.au>,
        <davem@...emloft.net>, <jarod@...hat.com>,
        <linux-crypto@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: tcrypt - fix return value for multiple subtests

On 9/30/2022 2:40 PM, Robert Elliott wrote:
> When a test mode invokes multiple tests (e.g., mode 0 invokes modes
> 1 through 199, and mode 3 tests three block cipher modes with des),
> don't keep accumulating the return values with ret += tcrypt_test(),
> which results in a bogus value if more than one report a nonzero
> value (e.g., two reporting -2 (-ENOENT) end up reporting -4 (-EINTR)).
> Instead, keep track of the minimum return value reported by any
> subtest.

I am assuming this is for the case when fips_enabled is true?

I agree that returning the cumulative sum or errors isn't particularly 
useful, but how is returning the minimum error value useful? Wouldn't it 
be more useful to return the first error return?

Ani