linux-kernel - Re: [PATCH 1/1] net: fec: add initial XDP support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 29 Sep 2022 05:18:21 +0800
From:   kernel test robot <lkp@...el.com>
To:     Shenwei Wang <shenwei.wang@....com>,
        Joakim Zhang <qiangqing.zhang@....com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        netdev@...r.kernel.org, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        linux-kernel@...r.kernel.org, imx@...ts.linux.dev,
        Shenwei Wang <shenwei.wang@....com>
Subject: Re: [PATCH 1/1] net: fec: add initial XDP support

Hi Shenwei,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]
[also build test WARNING on next-20220927]
[cannot apply to net/master linus/master v6.0-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shenwei-Wang/net-fec-add-initial-XDP-support/20220928-232917
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git b9a5cbf8ba24e88071a97a51a09ef5cdf0d1f6a1
config: arm-imx_v4_v5_defconfig
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/0ef976d16b5d6993db5c83926eaa836fc91a6450
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Shenwei-Wang/net-fec-add-initial-XDP-support/20220928-232917
        git checkout 0ef976d16b5d6993db5c83926eaa836fc91a6450
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/net/ethernet/freescale/ net/core/ net/ethtool/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/freescale/fec_main.c:3775:9: warning: variable 'nxmit' set but not used [-Wunused-but-set-variable]
           int i, nxmit = 0;
                  ^
   1 warning generated.


vim +/nxmit +3775 drivers/net/ethernet/freescale/fec_main.c

  3764	
  3765	static int fec_enet_xdp_xmit(struct net_device *dev,
  3766				     int num_frames,
  3767				     struct xdp_frame **frames,
  3768				     u32 flags)
  3769	{
  3770		struct fec_enet_private *fep = netdev_priv(dev);
  3771		struct fec_enet_priv_tx_q *txq;
  3772		int cpu = smp_processor_id();
  3773		struct netdev_queue *nq;
  3774		unsigned int queue;
> 3775		int i, nxmit = 0;
  3776	
  3777		queue = fec_enet_xdp_get_tx_queue(fep, cpu);
  3778		txq = fep->tx_queue[queue];
  3779		nq = netdev_get_tx_queue(fep->netdev, queue);
  3780	
  3781		__netif_tx_lock(nq, cpu);
  3782	
  3783		for (i = 0; i < num_frames; i++) {
  3784			fec_enet_txq_xmit_frame(fep, txq, frames[i]);
  3785			nxmit++;
  3786		}
  3787	
  3788		/* Make sure the update to bdp and tx_skbuff are performed. */
  3789		wmb();
  3790	
  3791		/* Trigger transmission start */
  3792		writel(0, txq->bd.reg_desc_active);
  3793	
  3794		__netif_tx_unlock(nq);
  3795	
  3796		return num_frames;
  3797	}
  3798	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (104647 bytes)