linux-kernel - Re: [PATCH -next v5 3/4] selftests/memory-hotplug: Adjust log info for maintainability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <23acdcfa-efd5-755d-6cd5-0631fd3a721c@redhat.com>
Date:   Fri, 30 Sep 2022 10:35:03 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Zhao Gongyi <zhaogongyi@...wei.com>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linux-kselftest@...r.kernel.org
Cc:     akinobu.mita@...il.com, corbet@....net, osalvador@...e.de,
        shuah@...nel.org
Subject: Re: [PATCH -next v5 3/4] selftests/memory-hotplug: Adjust log info
 for maintainability

On 30.09.22 08:35, Zhao Gongyi wrote:
> Redirect misleading error message to /dev/null for
> offline_memory_expect_success(), And, add an output
> for online->offline test.
> 
> Signed-off-by: Zhao Gongyi <zhaogongyi@...wei.com>
> ---
>   tools/testing/selftests/memory-hotplug/mem-on-off-test.sh | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> index 91a7457616bb..74ee5067a8ce 100755
> --- a/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> +++ b/tools/testing/selftests/memory-hotplug/mem-on-off-test.sh
> @@ -207,8 +207,11 @@ echo -e "\t trying to offline $target out of $hotpluggable_num memory block(s):"
>   for memory in `hotpluggable_online_memory`; do
>   	if [ "$target" -gt 0 ]; then
>   		echo "online->offline memory$memory"
> -		if offline_memory_expect_success $memory; then
> +		if offline_memory_expect_success $memory &>/dev/null; then
>   			target=$(($target - 1))
> +			echo "-> Success"
> +		else
> +			echo "-> Failure"
>   		fi
>   	fi
>   done
> @@ -267,7 +270,7 @@ prerequisite_extra
>   echo 0 > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_OFFLINE/error
>   for memory in `hotpluggable_online_memory`; do
>   	if [ $((RANDOM % 100)) -lt $ratio ]; then
> -		offline_memory_expect_success $memory
> +		offline_memory_expect_success $memory &>/dev/null

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb