lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAMGffE=PtSczoDckYPFO4azsrVqqAaGgp6Upup8WVYhk=O4X7w@mail.gmail.com> Date: Fri, 30 Sep 2022 11:15:33 +0200 From: Jinpu Wang <jinpu.wang@...os.com> To: John Garry <john.garry@...wei.com> Cc: jejb@...ux.ibm.com, martin.petersen@...cle.com, jinpu.wang@...os.com, damien.lemoal@....com, hare@...e.de, linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org, linuxarm@...wei.com, ipylypiv@...gle.com, changyuanl@...gle.com, hch@....de, yanaijie@...wei.com Subject: Re: [PATCH v2 1/6] scsi: libsas: Add sas_task_find_rq() On Fri, Sep 30, 2022 at 11:03 AM John Garry <john.garry@...wei.com> wrote: > > blk-mq already provides a unique tag per request. Some libsas LLDDs - like > hisi_sas - already use this tag as the unique per-IO HW tag. > > Add a common function to provide the request associated with a sas_task > for all libsas LLDDs. > > Signed-off-by: John Garry <john.garry@...wei.com> lgtm Reviewed-by: Jack Wang <jinpu.wang@...os.com> > --- > include/scsi/libsas.h | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h > index f86b56bf7833..f498217961db 100644 > --- a/include/scsi/libsas.h > +++ b/include/scsi/libsas.h > @@ -644,6 +644,24 @@ static inline bool sas_is_internal_abort(struct sas_task *task) > return task->task_proto == SAS_PROTOCOL_INTERNAL_ABORT; > } > > +static inline struct request *sas_task_find_rq(struct sas_task *task) > +{ > + struct scsi_cmnd *scmd; > + > + if (task->task_proto & SAS_PROTOCOL_STP_ALL) { > + struct ata_queued_cmd *qc = task->uldd_task; > + > + scmd = qc ? qc->scsicmd : NULL; > + } else { > + scmd = task->uldd_task; > + } > + > + if (!scmd) > + return NULL; > + > + return scsi_cmd_to_rq(scmd); > +} > + > struct sas_domain_function_template { > /* The class calls these to notify the LLDD of an event. */ > void (*lldd_port_formed)(struct asd_sas_phy *); > -- > 2.35.3 >
Powered by blists - more mailing lists