linux-kernel - Re: [PATCH 17/20] gpio/rockchip: print device with fwnode name when probe successful

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 30 Sep 2022 11:21:37 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Jianqun Xu <jay.xu@...k-chips.com>
Cc:     linus.walleij@...aro.org, heiko@...ech.de,
        andriy.shevchenko@...ux.intel.com, robert.moore@...el.com,
        robh@...nel.org, linux-rockchip@...ts.infradead.org,
        linux-kernel@...r.kernel.org, lenb@...nel.org, rafael@...nel.org
Subject: Re: [PATCH 17/20] gpio/rockchip: print device with fwnode name when
 probe successful

On Tue, Sep 20, 2022 at 12:31 PM Jianqun Xu <jay.xu@...k-chips.com> wrote:
>
> Print the device probe message with the fwnode instead of of_node.
>
> Signed-off-by: Jianqun Xu <jay.xu@...k-chips.com>
> ---
>  drivers/gpio/gpio-rockchip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
> index 11586d93549b..d08435619f12 100644
> --- a/drivers/gpio/gpio-rockchip.c
> +++ b/drivers/gpio/gpio-rockchip.c
> @@ -772,7 +772,7 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
>         }
>
>         platform_set_drvdata(pdev, bank);
> -       dev_info(dev, "probed %pOF\n", np);
> +       dev_info(dev, "probed %pfw\n", dev_fwnode(dev));
>
>         return 0;
>  err_put_clk:
> --
> 2.25.1
>

I would instead just drop this log message. If the user wants to, they
can obtain that information from the device core logs.

Bart