lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <20220930103428.21823-1-chenzhongjin@huawei.com>
Date:   Fri, 30 Sep 2022 18:34:28 +0800
From:   Chen Zhongjin <chenzhongjin@...wei.com>
To:     <linux-kernel@...r.kernel.org>, <linux-block@...r.kernel.org>
CC:     <axboe@...nel.dk>, <chenzhongjin@...wei.com>
Subject: [PATCH -next] block: Remove unused variable 'added'

Reported by Clang [-Wunused-but-set-variable]

'commit 480cb846c27b ("block: convert to advancing variants of iov_iter_get_pages{,_alloc}()")'
This commit converted iov_iter_advance() to iov_iter_revert(), and
not uses variable 'added' anymore but forgot to delete it.

Since 'added' is useless now, remove it for code cleaning.

Signed-off-by: Chen Zhongjin <chenzhongjin@...wei.com>
---
 block/blk-map.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/block/blk-map.c b/block/blk-map.c
index 7196a6b64c80..1d5e609589c0 100644
--- a/block/blk-map.c
+++ b/block/blk-map.c
@@ -251,7 +251,7 @@ static int bio_map_user_iov(struct request *rq, struct iov_iter *iter,
 	while (iov_iter_count(iter)) {
 		struct page **pages;
 		ssize_t bytes;
-		size_t offs, added = 0;
+		size_t offs;
 		int npages;
 
 		bytes = iov_iter_get_pages_alloc2(iter, &pages, LONG_MAX, &offs);
@@ -280,7 +280,6 @@ static int bio_map_user_iov(struct request *rq, struct iov_iter *iter,
 					break;
 				}
 
-				added += n;
 				bytes -= n;
 				offs = 0;
 			}
-- 
2.17.1

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ