linux-kernel - Re: [PATCH v2 3/4] dt-bindings: net: qcom,ethqos: Convert bindings to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9999a1a3-cda0-2759-f6f4-9bc7414f9ee4@linaro.org>
Date:   Fri, 30 Sep 2022 12:26:11 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Bhupesh Sharma <bhupesh.sharma@...aro.org>,
        devicetree@...r.kernel.org
Cc:     linux-arm-msm@...r.kernel.org, agross@...nel.org,
        bhupesh.linux@...il.com, linux-kernel@...r.kernel.org,
        robh+dt@...nel.org, netdev@...r.kernel.org,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh@...nel.org>, Vinod Koul <vkoul@...nel.org>,
        David Miller <davem@...emloft.net>
Subject: Re: [PATCH v2 3/4] dt-bindings: net: qcom,ethqos: Convert bindings to
 yaml

On 30/09/2022 10:12, Bhupesh Sharma wrote:
>>> +  snps,reset-gpio:
>>> +    maxItems: 1
>>
>> Why is this one here? It's already in snps,dwmac.
>>
>> Actually this applies to several other properties. You have
>> unevaluatedProperties:false, so you do not have to duplicate snps,dwmac.
>> You only need to constrain it, like we said about interrupts in your
>> previous patch.
> 
> I was actually getting errors like the following without the same:
> 
> arm64/boot/dts/qcom/qcs404-evb-1000.dtb: ethernet@...0000: Unevaluated 
> properties are not allowed ('snps,tso' was unexpected)
> 	From schema: Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> 
> So, its not clear to me that even though 'snps,dwmac.yaml' is referenced 
> here, the property appears as unevaluated.

Because snps,tso is not allowed, but the rest is.

> 
>>> +
>>> +  power-domains:
>>> +    maxItems: 1
>>> +
>>> +  resets:
>>> +    maxItems: 1
>>> +
>>> +  rx-fifo-depth:
>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>> +
>>> +  tx-fifo-depth:
>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>> +
>>> +  snps,tso:
>>> +    type: boolean
>>> +    description: Enables the TSO feature (otherwise managed by MAC HW capability register).
>>
>> You add here several new properties. Mention in commit msg changes from
>> pure conversion with answer to "why".
> 
> Right, most of them are to avoid the make dtbs_check errors / warnings 
> like the one mentioned above.

All of them should not be here.

Best regards,
Krzysztof