linux-kernel - Re: [PATCH 2/2] power: supply: rt9467: Add Richtek RT9467 charger driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 30 Sep 2022 10:26:24 +0800
From:   kernel test robot <lkp@...el.com>
To:     ChiaEn Wu <peterwu.pub@...il.com>, sre@...nel.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org
Cc:     kbuild-all@...ts.01.org, chiaen_wu@...htek.com,
        cy_huang@...htek.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 2/2] power: supply: rt9467: Add Richtek RT9467 charger
 driver

Hi ChiaEn,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on sre-power-supply/for-next]
[also build test WARNING on robh/for-next linus/master v6.0-rc7 next-20220929]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/ChiaEn-Wu/Add-Richtek-RT9467-5A-Battery-Charger-support/20220929-183906
base:   https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/042b1a763ec2948a412ff2a7fa500b98aace9923
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review ChiaEn-Wu/Add-Richtek-RT9467-5A-Battery-Charger-support/20220929-183906
        git checkout 042b1a763ec2948a412ff2a7fa500b98aace9923
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/power/supply/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/power/supply/rt9467-charger.c: In function 'rt9467_get_adc_raw_data':
   drivers/power/supply/rt9467-charger.c:436:43: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
     436 |         reg_val = RT9467_MASK_ADC_START | FIELD_PREP(RT9467_MASK_ADC_IN_SEL, adc_sel);
         |                                           ^~~~~~~~~~
   At top level:
>> drivers/power/supply/rt9467-charger.c:256:26: warning: 'rt9467_port_stat_names' defined but not used [-Wunused-const-variable=]
     256 | static const char *const rt9467_port_stat_names[RT9467_CHG_TYPE_MAX] = {
         |                          ^~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/rt9467_port_stat_names +256 drivers/power/supply/rt9467-charger.c

   255	
 > 256	static const char *const rt9467_port_stat_names[RT9467_CHG_TYPE_MAX] = {
   257		[RT9467_CHG_TYPE_NOVBUS]	= "No Vbus",
   258		[RT9467_CHG_TYPE_UNDER_GOING]	= "Under Going",
   259		[RT9467_CHG_TYPE_SDP]		= "SDP",
   260		[RT9467_CHG_TYPE_SDPNSTD]	= "SDPNSTD",
   261		[RT9467_CHG_TYPE_DCP]		= "DCP",
   262		[RT9467_CHG_TYPE_CDP]		= "CDP",
   263	};
   264	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (289549 bytes)