| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 30 Sep 2022 20:41:57 +0800
From: kernel test robot <lkp@...el.com>
To: sean.wang@...iatek.com, marcel@...tmann.org,
johan.hedberg@...il.com, luiz.dentz@...il.com
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
sean.wang@...iatek.com, Soul.Huang@...iatek.com,
YN.Chen@...iatek.com, Leon.Yen@...iatek.com,
Eric-SY.Chang@...iatek.com, Deren.Wu@...iatek.com,
km.lin@...iatek.com, robin.chiu@...iatek.com,
Eddie.Chen@...iatek.com, ch.yeh@...iatek.com,
posh.sun@...iatek.com, ted.huang@...iatek.com,
Stella.Chang@...iatek.com, Tom.Chou@...iatek.com,
steve.lee@...iatek.com, jsiuda@...gle.com, frankgor@...gle.com,
abhishekpandit@...gle.com, michaelfsun@...gle.com,
abhishekpandit@...omium.org, mcchou@...omium.org,
shawnku@...gle.com, linux-bluetooth@...r.kernel.org,
linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
Jing Cai <jing.cai@...iatek.com>
Subject: Re: [PATCH v2 3/3] Bluetooth: btusb: mediatek: add MediaTek
devcoredump support
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on bluetooth/master]
[also build test ERROR on bluetooth-next/master linus/master v6.0-rc7 next-20220929]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/sean-wang-mediatek-com/Bluetooth-btusb-mediatek-use-readx_poll_timeout-instead-of-open-coding/20220930-082512
base: https://git.kernel.org/pub/scm/linux/kernel/git/bluetooth/bluetooth.git master
config: i386-randconfig-a013
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/046dccfde843fe56b2ad741a42d972365bb70b03
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review sean-wang-mediatek-com/Bluetooth-btusb-mediatek-use-readx_poll_timeout-instead-of-open-coding/20220930-082512
git checkout 046dccfde843fe56b2ad741a42d972365bb70b03
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
drivers/bluetooth/btmtk.c:111:7: error: use of undeclared identifier 'HCI_DEVCOREDUMP_ACTIVE'; did you mean 'BTMTK_COREDUMP_ACTIVE'?
case HCI_DEVCOREDUMP_ACTIVE:
^~~~~~~~~~~~~~~~~~~~~~
BTMTK_COREDUMP_ACTIVE
drivers/bluetooth/btmtk.c:27:2: note: 'BTMTK_COREDUMP_ACTIVE' declared here
BTMTK_COREDUMP_ACTIVE,
^
drivers/bluetooth/btmtk.c:114:7: error: use of undeclared identifier 'HCI_DEVCOREDUMP_TIMEOUT'
case HCI_DEVCOREDUMP_TIMEOUT:
^
drivers/bluetooth/btmtk.c:115:7: error: use of undeclared identifier 'HCI_DEVCOREDUMP_ABORT'
case HCI_DEVCOREDUMP_ABORT:
^
drivers/bluetooth/btmtk.c:116:7: error: use of undeclared identifier 'HCI_DEVCOREDUMP_DONE'
case HCI_DEVCOREDUMP_DONE:
^
drivers/bluetooth/btmtk.c:376:2: error: implicit declaration of function 'hci_devcoredump_register' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
hci_devcoredump_register(hdev, btmtk_coredump, btmtk_coredump_hdr,
^
drivers/bluetooth/btmtk.c:393:9: error: implicit declaration of function 'hci_devcoredump_init' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
err = hci_devcoredump_init(hdev, 1024000);
^
>> drivers/bluetooth/btmtk.c:397:32: error: no member named 'dump' in 'struct hci_dev'
schedule_delayed_work(&hdev->dump.dump_timeout,
~~~~ ^
drivers/bluetooth/btmtk.c:402:9: error: implicit declaration of function 'hci_devcoredump_append' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
err = hci_devcoredump_append(hdev, skb);
^
drivers/bluetooth/btmtk.c:402:9: note: did you mean 'hci_devcoredump_init'?
drivers/bluetooth/btmtk.c:393:9: note: 'hci_devcoredump_init' declared here
err = hci_devcoredump_init(hdev, 1024000);
^
drivers/bluetooth/btmtk.c:409:4: error: implicit declaration of function 'hci_devcoredump_complete' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
hci_devcoredump_complete(hdev);
^
drivers/bluetooth/btmtk.c:409:4: note: did you mean 'hci_devcoredump_append'?
drivers/bluetooth/btmtk.c:402:9: note: 'hci_devcoredump_append' declared here
err = hci_devcoredump_append(hdev, skb);
^
9 errors generated.
vim +397 drivers/bluetooth/btmtk.c
380
381 int btmtk_process_coredump(struct hci_dev *hdev, struct sk_buff *skb)
382 {
383 int err;
384
385 if (!IS_ENABLED(CONFIG_DEV_COREDUMP))
386 return 0;
387
388 switch (coredump_info.state) {
389 case BTMTK_COREDUMP_DISABLED:
390 err = -EINVAL;
391 break;
392 case BTMTK_COREDUMP_INIT:
393 err = hci_devcoredump_init(hdev, 1024000);
394 if (err < 0)
395 break;
396 /* It is supposed coredump can be done within 5 seconds */
> 397 schedule_delayed_work(&hdev->dump.dump_timeout,
398 msecs_to_jiffies(5000));
399 fallthrough;
400 case BTMTK_COREDUMP_ACTIVE:
401 default:
402 err = hci_devcoredump_append(hdev, skb);
403 if (err < 0)
404 break;
405
406 if (skb->len > 12 &&
407 !strncmp((char *)&skb->data[skb->len - 13],
408 MTK_COREDUMP_END, 12))
409 hci_devcoredump_complete(hdev);
410
411 break;
412 }
413
414 if (err < 0) {
415 coredump_info.state = BTMTK_COREDUMP_DISABLED;
416 kfree_skb(skb);
417 }
418
419 return err;
420 }
421 EXPORT_SYMBOL_GPL(btmtk_process_coredump);
422
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (153775 bytes)
Powered by blists - more mailing lists