linux-kernel - Re: [PATCH v2] drivers/clk/clk: check return value of clk_pm_runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20220930002728.3A3C0C433C1@smtp.kernel.org>
Date:   Thu, 29 Sep 2022 17:27:26 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Li Zhong <floridsleeves@...il.com>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     mturquette@...libre.com, Li Zhong <floridsleeves@...il.com>
Subject: Re: [PATCH v2] drivers/clk/clk: check return value of clk_pm_runtime_get()

Quoting Li Zhong (2022-09-03 15:41:25)
> clk_pm_runtime_get() could fail. Check the return status.
> 
> Signed-off-by: Li Zhong <floridsleeves@...il.com>
> ---
>  drivers/clk/clk.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
> index 7fc191c15507..09353f7bf052 100644
> --- a/drivers/clk/clk.c
> +++ b/drivers/clk/clk.c
> @@ -2981,8 +2981,12 @@ static void clk_summary_show_subtree(struct seq_file *s, struct clk_core *c,
>                                      int level)
>  {
>         struct clk_core *child;
> +       int ret;
> +    
> +    ret = clk_pm_runtime_get(c);
> +    if (ret)
> +        return;
>  
> -       clk_pm_runtime_get(c);

The patch is malformed. It can't be applied, sorry. Also, shouldn't we
print something if we can't runtime PM get?

>         clk_summary_show_one(s, c, level);
>         clk_pm_runtime_put(c);
>