linux-kernel - Re: [PATCH v3] x86/mm/tlb: update some comments in pte_flags_need

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 29 Sep 2022 20:06:05 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Xin Hao <xhao@...ux.alibaba.com>, namit@...are.com
Cc:     tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, x86@...nel.org, peterz@...radead.org,
        hpa@...or.com, jroedel@...e.de, akpm@...ux-foundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] x86/mm/tlb: update some comments in
 pte_flags_need_flush



On 9/29/22 19:24, Xin Hao wrote:
> There just changed the comment about 'flush_on_clear' check, which make
> the explanation more reasonable.
> 
> Suggested-by: Nadav Amit <namit@...are.com>
> Suggested-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Xin Hao <xhao@...ux.alibaba.com>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
> 
> Changes from v2
> (https://lore.kernel.org/lkml/20220929091040.45390-1-xhao@linux.alibaba.com/)
> - fix some comments suggested-by Nadav Amit <namit@...are.com> and
> Randy Dunlap <rdunlap@...radead.org>
> 
>  arch/x86/include/asm/tlbflush.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h
> index cda3118f3b27..2a17698fb194 100644
> --- a/arch/x86/include/asm/tlbflush.h
> +++ b/arch/x86/include/asm/tlbflush.h
> @@ -291,8 +291,8 @@ static inline bool pte_flags_need_flush(unsigned long oldflags,
>  		diff &= ~_PAGE_ACCESSED;
> 
>  	/*
> -	 * Did any of the 'flush_on_clear' flags was clleared set from between
> -	 * 'oldflags' and 'newflags'?
> +	 * Consider the 'flush_on_clear' flags that are set on 'oldflags',
> +	 * Flush if any of these flags is cleared on 'newflags'.
>  	 */
>  	if (diff & oldflags & flush_on_clear)
>  		return true;
> --
> 2.31.0

-- 
~Randy