[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YzcVGN8v1yhgIlF6@pc636>
Date: Fri, 30 Sep 2022 18:11:04 +0200
From: Uladzislau Rezki <urezki@...il.com>
To: Joel Fernandes <joel@...lfernandes.org>
Cc: Uladzislau Rezki <urezki@...il.com>, paulmck@...nel.org,
rcu@...r.kernel.org, linux-kernel@...r.kernel.org,
rushikesh.s.kadam@...el.com, neeraj.iitr10@...il.com,
frederic@...nel.org, rostedt@...dmis.org
Subject: Re: [PATCH v6 1/4] rcu: Make call_rcu() lazy to save power
> >>
> >> OK. Found the boot up issue. In my case i had 120 seconds delay:
> >
> > Wow, nice work.
> >
> >> <snip>
> >> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> >> index 448748e3fba5..a56cfd612e3a 100644
> >> --- a/drivers/scsi/scsi_error.c
> >> +++ b/drivers/scsi/scsi_error.c
> >> @@ -312,7 +312,7 @@ void scsi_eh_scmd_add(struct scsi_cmnd *scmd)
> >> * Ensure that all tasks observe the host state change before the
> >> * host_failed change.
> >> */
> >> - call_rcu(&scmd->rcu, scsi_eh_inc_host_failed);
> >> + call_rcu_flush(&scmd->rcu, scsi_eh_inc_host_failed);
> >
> > Great! Thanks. I’ll include this and the other one you converted in the next revision.
>
> By the way, any chance you could check android as well, just to rule out any trouble markers? ChromeOS and your Linux distro are doing well on boot so that’s a good sign.
>
I will check v6 on Android. I will get back shortly.
> (Also let’s start trimming emails before Steven starts sending out nastygrams ;-)).
>
Done :)
--
Uladzislau Rezki
Powered by blists - more mailing lists