linux-kernel - Re: [PATCH] sched/core: Optimize the process of picking the max prio task for the core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 1 Oct 2022 00:24:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     Cruz Zhao <CruzZhao@...ux.alibaba.com>, mingo@...hat.com,
        peterz@...radead.org, juri.lelli@...hat.com,
        vincent.guittot@...aro.org, dietmar.eggemann@....com,
        rostedt@...dmis.org, bsegall@...gle.com, mgorman@...e.de,
        bristot@...hat.com, vschneid@...hat.com
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/core: Optimize the process of picking the max prio
 task for the core

Hi Cruz,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on tip/sched/core]
[also build test ERROR on linus/master v6.0-rc7 next-20220929]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Cruz-Zhao/sched-core-Optimize-the-process-of-picking-the-max-prio-task-for-the-core/20220929-152006
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 5aec788aeb8eb74282b75ac1b317beb0fbb69a42
config: s390-randconfig-r044-20220925
compiler: s390-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/606244fe4e02d08ecd6e2c97dbc2d344ad5e299e
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Cruz-Zhao/sched-core-Optimize-the-process-of-picking-the-max-prio-task-for-the-core/20220929-152006
        git checkout 606244fe4e02d08ecd6e2c97dbc2d344ad5e299e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=s390 SHELL=/bin/bash kernel/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from kernel/sched/core.c:84:
>> kernel/sched/sched.h:2157:14: error: field 'prio_less' declared as a function
    2157 |         bool prio_less(struct task_struct *a, struct task_struct *b, bool in_fi);
         |              ^~~~~~~~~
--
   In file included from kernel/sched/fair.c:54:
>> kernel/sched/sched.h:2157:14: error: field 'prio_less' declared as a function
    2157 |         bool prio_less(struct task_struct *a, struct task_struct *b, bool in_fi);
         |              ^~~~~~~~~
   kernel/sched/fair.c:11340:6: warning: no previous prototype for 'task_vruntime_update' [-Wmissing-prototypes]
   11340 | void task_vruntime_update(struct rq *rq, struct task_struct *p, bool in_fi)
         |      ^~~~~~~~~~~~~~~~~~~~


vim +/prio_less +2157 kernel/sched/sched.h

  2144	
  2145		void (*enqueue_task) (struct rq *rq, struct task_struct *p, int flags);
  2146		void (*dequeue_task) (struct rq *rq, struct task_struct *p, int flags);
  2147		void (*yield_task)   (struct rq *rq);
  2148		bool (*yield_to_task)(struct rq *rq, struct task_struct *p);
  2149	
  2150		void (*check_preempt_curr)(struct rq *rq, struct task_struct *p, int flags);
  2151	
  2152		struct task_struct *(*pick_next_task)(struct rq *rq);
  2153	
  2154		void (*put_prev_task)(struct rq *rq, struct task_struct *p);
  2155		void (*set_next_task)(struct rq *rq, struct task_struct *p, bool first);
  2156	#ifdef CONFIG_SCHED_CORE
> 2157		bool prio_less(struct task_struct *a, struct task_struct *b, bool in_fi);
  2158	#endif
  2159	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (117640 bytes)