linux-kernel - Re: [PATCH 3/3] tpm: st33zp24: remove pointless checks on probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 30 Sep 2022 21:13:08 -0700
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Jarkko Sakkinen <jarkko@...nel.org>
Cc:     Peter Huewe <peterhuewe@....de>, Jason Gunthorpe <jgg@...pe.ca>,
        linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] tpm: st33zp24: remove pointless checks on probe

On Fri, Sep 30, 2022 at 11:44:21PM +0300, Jarkko Sakkinen wrote:
> On Sun, Sep 25, 2022 at 10:39:58PM -0700, Dmitry Torokhov wrote:
> > Driver core will never call driver's probe method without appropriate
> > device structure, so testing them for NULL is pointless.
> > 
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> 
> Missing a description what the patch does.
> 
> Also instead of "driver's probe method" you could just use
> "st33zp24_i2c_probe()". It's even shorter.

There are 2 interfaces: I2C and SPI, thus 2 separate probe methods.

Thanks.

-- 
Dmitry